[MDEV-24115] Build failure on MacOS on compiling the file btr/btr0btr.cc Created: 2020-11-04 Updated: 2020-11-17 Resolved: 2020-11-17 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Compiling |
| Affects Version/s: | 10.5, 10.6 |
| Fix Version/s: | 10.4.18, 10.5.9 |
| Type: | Bug | Priority: | Major |
| Reporter: | Dmitry Shulga | Assignee: | Dmitry Shulga |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Attempt to build MariaDB server on mac OS leads to compilation error:
|
| Comments |
| Comment by Dmitry Shulga [ 2020-11-05 ] | ||
|
The patch is ready for review in the branch bb-10.5- | ||
| Comment by Sergei Golubchik [ 2020-11-09 ] | ||
|
ifdefs aren't particularly good for maintainability and readability. Why not to cast unconditionally? Or to use uint for the constructor argument? | ||
| Comment by Dmitry Shulga [ 2020-11-10 ] | ||
|
Timeval is widely used across the source code and some of methods (e.g. Field::store_timestamp) Changing types of argument in every method that calls Timeval constructor requires more changes than just one cast inside constructor of Timeval | ||
| Comment by Sergei Golubchik [ 2020-11-10 ] | ||
|
ok. by "cast unconditionally" I meant
although uint might work too | ||
| Comment by Dmitry Shulga [ 2020-11-11 ] | ||
|
The type suseconds_t conforms to POSIX.1-2001 and later. |