[MDEV-23935] Fix warnings generated during compilation of plugin/auth_pam/testing/pam_mariadb_mtr.c on MacOS Created: 2020-10-11  Updated: 2021-01-19  Resolved: 2020-10-22

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.4.15
Fix Version/s: 10.4.16, 10.5.7

Type: Bug Priority: Major
Reporter: Dmitry Shulga Assignee: Dmitry Shulga
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-24577 Fix warnings generated during compila... Closed

 Description   

During build server 10.4 on MacOS the following warnings are generated on compiling the file plugin/auth_pam/testing/pam_mariadb_mtr.c

server-10.4/plugin/auth_pam/testing/pam_mariadb_mtr.c:25:22: error:
      initializing 'char *' with an expression of type 'const char [23]' discards qualifiers
      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    { PAM_TEXT_INFO, "Challenge input first." },
                     ^~~~~~~~~~~~~~~~~~~~~~~~
server-10.4/plugin/auth_pam/testing/pam_mariadb_mtr.c:26:28: error:
      initializing 'char *' with an expression of type 'const char [7]' discards qualifiers
      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    { PAM_PROMPT_ECHO_OFF, "Enter:" },
                           ^~~~~~~~
server-10.4/plugin/auth_pam/testing/pam_mariadb_mtr.c:27:22: error:
      initializing 'char *' with an expression of type 'const char [23]' discards qualifiers
      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    { PAM_ERROR_MSG, "Now, the magic number!" }
                     ^~~~~~~~~~~~~~~~~~~~~~~~
server-10.4/plugin/auth_pam/testing/pam_mariadb_mtr.c:49:16: error:
      assigning to 'char *' from 'const char [5]' discards qualifiers
      [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    msg[0].msg = "PIN:";
               ^ ~~~~~~

In case MariaDB serer is build with -DCMAKE_BUILD_TYPE=Debug it results in build error.
In other words, debug build can't be finished successfully on MacOS 10.4 and higher.



 Comments   
Comment by Marcin Gryszkalis [ 2021-01-11 ]

It's not only MacOS, on FreeBSD (tested on 11.x) it's the same.

cc is llvm

FreeBSD clang version 10.0.0 (git@github.com:llvm/llvm-project.git llvmorg-10.0.0-0-gd32170dbd5b)
Target: x86_64-unknown-freebsd11.4

/usr/ports/databases/mariadb104-server/work/mariadb-10.4.17/plugin/auth_pam/testing/pam_mariadb_mtr.c:25:22: error: initializing 'char *' with an expression of type 'const char [23]' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    { PAM_TEXT_INFO, "Challenge input first." },
                     ^~~~~~~~~~~~~~~~~~~~~~~~

Generated at Thu Feb 08 09:26:10 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.