[MDEV-23892] Fails to compile on platforms that require libatomic Created: 2020-10-06 Updated: 2021-10-22 Resolved: 2021-10-22 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Compiling |
| Affects Version/s: | 10.3.24 |
| Fix Version/s: | 10.3.32, 10.4.22, 10.5.13, 10.6.5, 10.7.1 |
| Type: | Bug | Priority: | Major |
| Reporter: | Daniel Black | Assignee: | Vicențiu Ciorbaru |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
aix / riscv64 |
||
| Issue Links: |
|
||||||||||||||||
| Description |
|
required by Risc64 - https://salsa.debian.org/mariadb-team/mariadb-10.3/blob/master/debian/patches/c11_atomics.patch ref: |
| Comments |
| Comment by Vicențiu Ciorbaru [ 2020-11-18 ] | |||||||||||
|
Ok, some progress finally with the AIX build. This commit: https://github.com/MariaDB/server/pull/1515/commits/fc1884e45fb209e639636292ed4e9a326a015f63 makes the libatomic check unnecessary. What I've discovered is by default, AIX compiler builds 32 bit apps, which don't have __sync_xxx_8 methods, which leads to compilation failure. Setting -maix64 will make the process succeed. | |||||||||||
| Comment by Vicențiu Ciorbaru [ 2020-11-18 ] | |||||||||||
|
The patch that is now in debian should however be incorporated into MariaDB, as it solved a compilation failure for mips. | |||||||||||
| Comment by Otto Kekäläinen [ 2020-12-08 ] | |||||||||||
|
Perhaps related failure on risc64:
| |||||||||||
| Comment by Otto Kekäläinen [ 2020-12-21 ] | |||||||||||
|
Related: | |||||||||||
| Comment by Daniel Black [ 2021-01-10 ] | |||||||||||
|
AIX adding -pthread to cflags is largely the same effect as #1717 so it sounds like the right way to go. | |||||||||||
| Comment by Daniel Black [ 2021-04-15 ] | |||||||||||
|
pthread pushed to 10.3 Will process https://github.com/MariaDB/server/pull/1716 the libatomic bit next. |