[MDEV-23697] not valid shebang Created: 2020-09-08 Updated: 2020-10-06 Resolved: 2020-09-23 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Scripts & Clients |
| Affects Version/s: | 10.1.46, 10.2.33, 10.3.24, 10.4.14, 10.5.5 |
| Fix Version/s: | 10.1.48, 10.2.35, 10.3.26, 10.4.16, 10.5.7 |
| Type: | Bug | Priority: | Major |
| Reporter: | Alexey Shabalin | Assignee: | Daniel Black |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Commit
– valid
– valid
– valid
– not valid |
| Comments |
| Comment by Faustin Lammler [ 2020-09-23 ] | |||||||||||
|
On Debian (mariadb 10.3.24), there is also a dependency problem, we install libdbd-mariadb-perl but mytop requires libdbd-mysql-perl. | |||||||||||
| Comment by Otto Kekäläinen [ 2020-09-23 ] | |||||||||||
|
Just for the record, the perl -w option is to print out warnings and https://manpages.debian.org/buster/perl-base/perl.1.en.html#DIAGNOSTICS In 10.5.5 mytop is not using -w anymore. Only mariadb-report and some The format "env perl" should not be used at all, it should always be "/usr/bin/perl" (at lest in Debian, https://www.debian.org/doc/debian-policy/ch-files.html#scripts) but for some reason it was reverted for innotop in https://github.com/MariaDB/server/commit/dbd1d7ea8e96a2b4cff89ec889494700d634b3a3 | |||||||||||
| Comment by Daniel Black [ 2020-09-23 ] | |||||||||||
|
env is a stop gap until a better universal detection mechanism for the path of perl is determined and replaced in each script, because its not all about Debian. I'll take a debian policy violation compared to 'perl not found' on another platform. -w removed from all scripts. Looking at scripts, its questionable as to why those scripts are there.
Thanks for the bug report shaba | |||||||||||
| Comment by Otto Kekäläinen [ 2020-09-24 ] | |||||||||||
|
> env is a stop gap until a better universal detection mechanism for the path of perl is determined Sure, it is not "all about Debian" but in my experience typically the things that end up in the Debian policy are pretty universal good practices. There were some comments in your commits about FreeBSD not supporting /usr/bin/perl but I did not find any details about FreeBSD's policy on this. According to https://lists.freebsd.org/pipermail/freebsd-ports/2013-October/087104.html FreeBSD has had /usr/bin/perl at least since 2013. |