[MDEV-23479] Add a THD* argument to Item_func_or_sum::fix_length_and_dec() Created: 2020-08-14 Updated: 2022-04-25 Resolved: 2022-03-30 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER |
| Fix Version/s: | 10.9.1 |
| Type: | Task | Priority: | Minor |
| Reporter: | Alexander Barkov | Assignee: | Rucha Deodhar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Let's add a THD * parameter to Item_func_or_sum::fix_length_and_dec(). We use current_thd frequently in fix_length_and_dec(): For certain data types, like TIME/DATETIME/DATE, THD is needed in the majority of Item_func_xxx, because they need access to thd->variables.sql_mode, for:
All hybrid type functions also need thd for the same reason (when returning TIME/DATETIME/DATE). Also, the following sql_mode flags are tested in fix_length_and_dec():
Many functions access THD in fix_length_and_dec() for other reasons than sql_mode:
|
| Comments |
| Comment by Rucha Deodhar [ 2022-01-26 ] |
|
Patch: https://github.com/MariaDB/server/commit/4abcb43f56caadfeee0ebf893d3f815ebc7a6cb2 |
| Comment by Oleksandr Byelkin [ 2022-03-28 ] |
|
OK to push |
| Comment by Oleksandr Byelkin [ 2022-03-28 ] |
|
OK to push |