[MDEV-23361] S3 storage engine does not build Created: 2020-08-01  Updated: 2020-10-26  Resolved: 2020-10-26

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - S3
Affects Version/s: None
Fix Version/s: 10.5.7

Type: Bug Priority: Blocker
Reporter: Brad Smith Assignee: Sergei Golubchik
Resolution: Fixed Votes: 0
Labels: None


 Description   

The S3 storage engine does not build..

[772/1647] /home/ports/pobj/mariadb-10.5.4/bin/cc -DDBUG_TRACE -DHAVE_CONFIG_H -DWITH_S3_STORAGE_ENGINE -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/wsrep-lib/include -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/wsrep-lib/wsrep-API/v26 -Iinclude -I/home/po
rts/pobj/mariadb-10.5.4/mariadb-10.5.4/include -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/sql -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/storage/maria/libmarias3 -O2 -pipe  -I/usr/local/include -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-s
ize=4 -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -MD -MT storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias3.c.o -MF storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias3.c.o.d -o storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias
3.c.o   -c /home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/storage/maria/libmarias3/src/marias3.c
FAILED: storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias3.c.o
/home/ports/pobj/mariadb-10.5.4/bin/cc -DDBUG_TRACE -DHAVE_CONFIG_H -DWITH_S3_STORAGE_ENGINE -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/wsrep-lib/include -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/wsrep-lib/wsrep-API/v26 -Iinclude -I/home/ports/pobj/ma
riadb-10.5.4/mariadb-10.5.4/include -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/sql -I/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/storage/maria/libmarias3 -O2 -pipe  -I/usr/local/include -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DNDE
BUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -MD -MT storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias3.c.o -MF storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias3.c.o.d -o storage/maria/CMakeFiles/aria_s3_copy.dir/libmarias3/src/marias3.c.o   -c
/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/storage/maria/libmarias3/src/marias3.c
cc: warning: -Wl,-z,relro,-z,now: 'linker' input unused [-Wunused-command-line-argument]
/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/storage/maria/libmarias3/src/marias3.c:172:24: error: variable has incomplete type 'struct sockaddr_in'
    struct sockaddr_in sa;
                       ^
/home/ports/pobj/mariadb-10.5.4/mariadb-10.5.4/storage/maria/libmarias3/src/marias3.c:172:12: note: forward declaration of 'struct sockaddr_in'
    struct sockaddr_in sa;
           ^
1 error generated.

I have this patch for this issue...
http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/databases/mariadb/patches/patch-storage_maria_libmarias3_src_marias3_c?rev=1.1&content-type=text/plain&hideattic=1



 Comments   
Comment by Daniel Black [ 2020-08-01 ]

We saw similar with FreeBSD - MDEV-23176

Can you submit a pull request that extends the FreeBSD define check to something that include OpenBSD too?

FreeBSD fix and repository:
https://github.com/mariadb-corporation/libmarias3/pull/87/files

Comment by Brad Smith [ 2020-09-09 ]

A DragonFly BSD user has created a pull request awhile ago that resolves the issue.

https://github.com/mariadb-corporation/libmarias3/pull/89

Generated at Thu Feb 08 09:21:49 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.