[MDEV-23109] Move `flush()` function call into `inc_group_relay_log_pos()` Created: 2020-07-07 Updated: 2023-12-15 |
|
| Status: | In Review |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Affects Version/s: | 10.1, 10.2, 10.3, 10.4, 10.5, 10.6 |
| Fix Version/s: | 10.6 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Sujatha Sivakumar (Inactive) | Assignee: | Andrei Elkin |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Relocate `flush()` into `inc_group_relay_log_pos()` to avoid invocation of mysql_mutex_lock(&data_lock)/unlock twice. |
| Comments |
| Comment by Sujatha Sivakumar (Inactive) [ 2020-12-08 ] |
|
Hello Andrei, I didn't relocate 'flush()' function call into 'inc_group_relay_log_pos'. https://github.com/MariaDB/server/commit/4d2b40dde11522dd67b7f93f81b609132441ed3e Thank you. |
| Comment by Sujatha Sivakumar (Inactive) [ 2020-12-18 ] |
|
Hello Elkin Please find the following comment which explains the reason for not flushing relay-log.info and the end of event
Do not update relay-log.info and master.info on disk after every event
The files are still written at normal slave stop. In non-GTID mode, the files are written as normal (this is needed to |
| Comment by Andrei Elkin [ 2023-12-15 ] |
|
The status confirmed. The review should be completed, preferably by myself, to make the patch into the upcoming CS release. |