[MDEV-22894] Mariabackup should not read [mariadb-client] option group from configuration files Created: 2020-06-14  Updated: 2020-09-08  Resolved: 2020-09-08

Status: Closed
Project: MariaDB Server
Component/s: mariabackup
Affects Version/s: 10.4, 10.5
Fix Version/s: 10.5.4, 10.4.14

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Vladislav Lesin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-18215 mariabackup does not report unknown c... Closed
is caused by MDEV-21298 mariabackup doesn't read from the [ma... Closed
is caused by MDEV-21301 mariabackup doesn't read [mariadb-bac... Closed
Relates
relates to MDEV-22983 Mariabackup's --help option disappeared Closed

 Description   

The fix for MDEV-18215 / MDEV-21298 / MDEV-21301 improperly added the [mariadb-client] option group to Mariabackup's client option groups:

https://github.com/MariaDB/server/blob/9bdf35e90f36d9be8cc7591e2ed5e62feadc5515/extra/mariabackup/xtrabackup.cc#L1628

This is incorrect.

The [mariadb-client] option group is used by the "mysql" / "mariadb" command-line client. The [mariadb-client] option group is not a "generic" client option group read by all client programs.

Mariabackup should only read the "generic" client option groups listed in sql-common/client.c:

https://github.com/MariaDB/server/blob/9bdf35e90f36d9be8cc7591e2ed5e62feadc5515/sql-common/client.c#L854

Those option groups are:

  • [client]
  • [client-server]
  • [client-mariadb]
Generated at Thu Feb 08 09:18:17 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.