[MDEV-22592] Travis-CI broken for 10.5 in recent commit - Why does nobody care? Created: 2020-05-16 Updated: 2020-10-13 Resolved: 2020-10-13 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | N/A |
| Affects Version/s: | 10.5 |
| Fix Version/s: | N/A |
| Type: | Bug | Priority: | Critical |
| Reporter: | Otto Kekäläinen | Assignee: | Sergei Golubchik |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Description |
|
I noticed that Travis-CI has stopped passing for the 10.5 branch: Last successful one: First failing one: (there are also a couple cancelled in between) The failure is due to https://jira.mariadb.org/browse/MDEV-21976 (currently assigned to sanja but no work yet). Fixing that issue would solve it permanently. However, since it is not fixed, it was disabled by me in https://github.com/MariaDB/server/commit/a135f0ab88d63b9a8976d6b3010f27766c38873d (when https://github.com/MariaDB/server/pull/1484 was merged by marko). This change to mysql-test/unstable-tests was lost in a merge commit. The fix to this is trivial: add back the line in mysql-test/unstable-tests. However, the underlying issue here is that current MariaDB Server practices allow Travis-CI to be broken, and effectively after that:
And so on. I hope you get the point why failing CI is bad and how it is counter-productive and wastes a lot of human resources that is away from productive development. Now what can be do about this? Is there a need for more education? Travis-CI was added as the first and only CI system accessible to outside contributors in August 2016. Surely all developers have had a chance to learn about it? Or is there some obstacles? Should we maybe organize a webinar where we quickly go through what Travis-CI is, what the lines in .travis.yml mean and how to browser Travis-CI.org to look at build results or debug them? Are the Travis-CI tests bad? There are no open bug reports on Jira about any complaints about Travis-CI. I think the underlying problem here is the same reason why there are so many failures on buildbot.askmonty.org and buildbot.mariadb.org as well. Way too many people are taking the wrong tradeoff in the decision about "Just get it done and move on, don't wait for tests" vs "Work on something else, only merge once tests complete". What do you think? What should be done about this to improve the situation, to improve the quality of MariaDB both by current developers and future contributors, and speed up the progress by having less breakage and steps backwards? |
| Comments |
| Comment by Otto Kekäläinen [ 2020-05-16 ] | ||||
|
Commit https://github.com/MariaDB/server/pull/1463/commits/5d85bc08c6412d067a69d2c1354a10f9a803b332 will make Travis-CI green again, but the root problem here remains, thus not closing issue. Screenshot to illustrate how it looks like when the CI is permanently broken and all Pull Requests are deemed failing on automatic tests: Note the red cross next to titles. | ||||
| Comment by Sergei Golubchik [ 2020-05-18 ] | ||||
|
The issue is, as you know, that out CI at the moment is https://buildbot.askmonty.org/buildbot/ If developers don't use Travis CI, they won't look to see if it's broken. | ||||
| Comment by Otto Kekäläinen [ 2020-05-18 ] | ||||
|
Travis CI is integrated into Github, and visible there in every Shouldn't developers be happy if some system automatically detects a | ||||
| Comment by Marko Mäkelä [ 2020-05-18 ] | ||||
|
I cared enough to close | ||||
| Comment by Daniel Black [ 2020-05-19 ] | ||||
|
arm64, ppc64le, s390x all have multiple space/quota issues reported to travis - https://travis-ci.community/c/environments/multi-cpu-arch/96 and largely ignored (arm64 I think got a quote bump at some point, though I suspect its there's an aspect of it is never getting reset back to a number at the start of the build, or residual allocation somehow). This is not always related to the install - just installing apt dependencies - https://travis-ci.org/github/MariaDB/server/jobs/687470429 triggered this failure. I'm fairly sure the repo isn't even cloned at this point. | ||||
| Comment by Marko Mäkelä [ 2020-05-19 ] | ||||
|
After my merge to 10.5, apart from the quota issues that danblack mentioned, it looks like we only got a Mac OS X failure that ought to be fixed when | ||||
| Comment by Otto Kekäläinen [ 2020-05-19 ] | ||||
|
danblack If there are problems it particular test jobs being unstable and producing false positives, then we can just exclude or ignore them so that the build is green. So far my own experience is that when I branch off from a master branch and start developing something, I need to debug and report a bunch or real test failures first which have been ignored before I actually get to test the thing I am changing myself. | ||||
| Comment by Otto Kekäläinen [ 2020-08-03 ] | ||||
|
Currently these branches at https://travis-ci.org/github/MariaDB/server/branches are green:
The 10.3 was green but 2 most recent builds turned red: In 10.2 the build has been broken for a longer while, so maybe just delete the .travis-ci.yml file from that branch to avoid spending time on that one? It's not helping any testing now. | ||||
| Comment by Marko Mäkelä [ 2020-08-03 ] | ||||
|
otto, for a recent 10.3 build https://travis-ci.org/github/MariaDB/server/builds/714262380 I see two failures apparently due to bad connectivity when trying to download clang: For a 10.2 build, I see something else:
There does not appear to be any bug report for this memory leak yet. In my opinion, the proverb that I heard at the compulsory service of the Finnish defence force applies: "Valvomaton käsky on kasku." (An unenforced order is a joke.) If nobody spends effort on monitoring Travis test failures, they are going to be rather useless. Build failures probably do bring some more value (if someone notices them before the breakage reaches a release). | ||||
| Comment by Otto Kekäläinen [ 2020-08-03 ] | ||||
|
If there are a lot of false positives, then I suggest we simply disable those tests. It will also make the suite run faster. Once Ubuntu 20.04 is available on Travis-CI we can get rid of those extra dependencies and thus streamline the config. WIP at https://github.com/MariaDB/server/pull/1507 | ||||
| Comment by Marko Mäkelä [ 2020-08-03 ] | ||||
|
For the genuine 10.2 failure, I filed | ||||
| Comment by Otto Kekäläinen [ 2020-10-13 ] | ||||
|
Nice to see that nowadays Travis-CI seems to be all green and people are not ignoring the results of it! Thanks! Screenshots from https://travis-ci.org/github/MariaDB/server/branches | ||||
| Comment by Daniel Black [ 2020-10-13 ] | ||||
|
|