[MDEV-22578] thread_pool_info crashes with clang6, using SSE instructions on unaligned memory Created: 2020-05-15  Updated: 2020-05-15  Resolved: 2020-05-15

Status: Closed
Project: MariaDB Server
Component/s: Server
Affects Version/s: 10.5
Fix Version/s: 10.5.4

Type: Bug Priority: Major
Reporter: Vladislav Vaintroub Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-5205 MariaDB does not start if more than 1... Closed

 Description   


 Comments   
Comment by Vladislav Vaintroub [ 2020-05-15 ]

69077dea25f6e7cab4ff8927e4429ad62af9de49

Comment by Marko Mäkelä [ 2020-05-15 ]

wlad, I think that a better fix would have been to use aligned_malloc(), which is guaranteed to be available already in MariaDB Server 10.2. Just move the function declaration from InnoDB to somewhere where it is globally usable.

Comment by Vladislav Vaintroub [ 2020-05-15 ]

marko, I don't disagree that it would be a slightly better fix, yet I'm wondering how much effort would be needed to make that aligned_malloc also aligned with the whole mysys stuff, like safemalloc and the memory accounting, and the PSI in 10.5 . Probably it would also need to be exported via server services. If I think about all that vs 2 lines fix, I choose 2 lines.
That does not mean, my_aligned_malloc should not be done, but not in scope of that fix.

Generated at Thu Feb 08 09:15:50 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.