[MDEV-22531] Remove maria::implicit_commit() Created: 2020-05-12  Updated: 2020-05-26  Resolved: 2020-05-26

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Aria
Fix Version/s: 10.5.4

Type: Task Priority: Major
Reporter: Michael Widenius Assignee: Michael Widenius
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-22468 BACKUP STAGE BLOCK_COMMIT should bloc... Closed

 Description   

There are three calls to maria::implicit_commit() to ensure that Aria transactions are committed. These are needed because Aria is not registering it's transactions into the MariaDB transaction system.

The purpose of this task is have Aria to register it's transactions and remove the calls to maria::implicit_commit(). This will give a small speed improvement when not using Aria tables and make the code more uniform.

Some consequences of this change are:

  • All usage of Aria system tables (open_system_table_for_read(), using status tables etc) must do proper commits of statement and transaction.
  • We need a new way to start independent transactions when we use system tables or status tables. This should be done in a way to minimize code changes.

After the above changes is done, it would be relatively easy to add support for other engines to use mysql.* system tables if and when it's needed.



 Comments   
Comment by Michael Widenius [ 2020-05-26 ]

Reviews and discussions

Generated at Thu Feb 08 09:15:26 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.