[MDEV-22355] remove unused return value of copy_back() in mariabackup Created: 2020-04-23  Updated: 2020-09-08  Resolved: 2020-09-08

Status: Closed
Project: MariaDB Server
Component/s: mariabackup
Affects Version/s: 10.2, 10.3, 10.4, 10.5
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Vladislav Lesin Assignee: Vladislav Lesin
Resolution: Not a Bug Votes: 0
Labels: None


 Description   

When does copy_back() return anything else than false? It seems that the variable ret is completely redundant. Highlighted by this:

/mariadb/10.4/extra/mariabackup/backup_copy.cc:1785:7: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
 
 1785 |  bool ret;

Check if there is a code which expects return value from the function and verify it's correctness.

 Comments   
Comment by Vladislav Lesin [ 2020-09-08 ]

The return value of copy_back() is used.

Generated at Thu Feb 08 09:14:06 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.