[MDEV-22237] Assertion `!table->file->keyread_enabled()' failed in handler::ha_reset on DELETE Created: 2020-04-14  Updated: 2020-04-20  Resolved: 2020-04-20

Status: Closed
Project: MariaDB Server
Component/s: Data Manipulation - Delete, Data Manipulation - Update
Affects Version/s: 10.5
Fix Version/s: 10.5.3

Type: Bug Priority: Critical
Reporter: Roel Van de Paar Assignee: Michael Widenius
Resolution: Fixed Votes: 0
Labels: not-10.1, not-10.2, not-10.3, not-10.4, regression

Issue Links:
Relates
relates to MDEV-22062 Assertion `!table->file->keyread_enab... Closed

 Description   

--source include/have_innodb.inc
 
USE test;
CREATE TABLE t (a CHAR KEY,b BLOB) ENGINE=InnoDB;
DELETE FROM t ORDER BY a LIMIT 1;

Leads to:

10.5.3 364e7a9ae6b5fbf69494cec30733b5ad28738cbb

mysqld: /test/10.5_dbg/sql/handler.cc:6517: int handler::ha_reset(): Assertion `!table->file->keyread_enabled()' failed.

10.5.3 364e7a9ae6b5fbf69494cec30733b5ad28738cbb

Core was generated by `/test/MD110420-mariadb-10.5.3-linux-x86_64-dbg/bin/mysqld --no-defaults --core-'.
Program terminated with signal SIGABRT, Aborted.
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6)
    at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
[Current thread is 1 (Thread 0x7f1d93d83700 (LWP 17916))]
(gdb) bt
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
#1  0x000055b3d2bcb21e in my_write_core (sig=sig@entry=6) at /test/10.5_dbg/mysys/stacktrace.c:518
#2  0x000055b3d237108f in handle_fatal_signal (sig=6) at /test/10.5_dbg/sql/signal_handler.cc:329
#3  <signal handler called>
#4  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#5  0x00007f1d924c7801 in __GI_abort () at abort.c:79
#6  0x00007f1d924b739a in __assert_fail_base (fmt=0x7f1d9263e7d8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x55b3d2d2dc00 "!table->file->keyread_enabled()", file=file@entry=0x55b3d2ed3982 "/test/10.5_dbg/sql/handler.cc", line=line@entry=6517, function=function@entry=0x55b3d2ed7000 <handler::ha_reset()::__PRETTY_FUNCTION__> "int handler::ha_reset()") at assert.c:92
#7  0x00007f1d924b7412 in __GI___assert_fail (assertion=assertion@entry=0x55b3d2d2dc00 "!table->file->keyread_enabled()", file=file@entry=0x55b3d2ed3982 "/test/10.5_dbg/sql/handler.cc", line=line@entry=6517, function=function@entry=0x55b3d2ed7000 <handler::ha_reset()::__PRETTY_FUNCTION__> "int handler::ha_reset()") at assert.c:101
#8  0x000055b3d2383718 in handler::ha_reset (this=0x7f1d6642cea0) at /test/10.5_dbg/sql/handler.cc:6517
#9  0x000055b3d22d6656 in THD::mark_tmp_table_as_free_for_reuse (this=this@entry=0x7f1d66415088, table=0x7f1d664c9088) at /test/10.5_dbg/sql/temporary_tables.cc:789
#10 0x000055b3d22d837e in THD::mark_tmp_tables_as_free_for_reuse (this=this@entry=0x7f1d66415088) at /test/10.5_dbg/sql/temporary_tables.cc:751
#11 0x000055b3d2040acf in close_thread_tables (thd=thd@entry=0x7f1d66415088) at /test/10.5_dbg/sql/sql_base.cc:859
#12 0x000055b3d20cd96a in mysql_execute_command (thd=thd@entry=0x7f1d66415088) at /test/10.5_dbg/sql/sql_parse.cc:5976
#13 0x000055b3d20d49d1 in mysql_parse (thd=thd@entry=0x7f1d66415088, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x7f1d93d82450, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:7953
#14 0x000055b3d20c0719 in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x7f1d66415088, packet=packet@entry=0x7f1d66467089 "DELETE FROM t ORDER BY a LIMIT 1", packet_length=packet_length@entry=32, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:1839
#15 0x000055b3d20bef6f in do_command (thd=0x7f1d66415088) at /test/10.5_dbg/sql/sql_parse.cc:1358
#16 0x000055b3d2219a53 in do_handle_one_connection (connect=<optimized out>, connect@entry=0x7f1d6c8433a8, put_in_cache=put_in_cache@entry=true) at /test/10.5_dbg/sql/sql_connect.cc:1422
#17 0x000055b3d2219d82 in handle_one_connection (arg=arg@entry=0x7f1d6c8433a8) at /test/10.5_dbg/sql/sql_connect.cc:1319
#18 0x000055b3d267a080 in pfs_spawn_thread (arg=0x7f1d91845888) at /test/10.5_dbg/storage/perfschema/pfs.cc:2201
#19 0x00007f1d931aa6db in start_thread (arg=0x7f1d93d83700) at pthread_create.c:463
#20 0x00007f1d925a888f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Bug confirmed present in:
MariaDB: 10.5.3 (dbg)

Bug confirmed not present in:
MariaDB: 10.1.45 (dbg), 10.1.45 (opt), 10.2.32 (dbg), 10.2.32 (opt), 10.3.23 (dbg), 10.3.23 (opt), 10.4.13 (dbg), 10.4.13 (opt), 10.5.2 (dbg), 10.5.2 (opt), 10.5.3 (opt)
MySQL: 5.5.62 (dbg), 5.5.62 (opt), 5.6.47 (dbg), 5.6.47 (opt), 5.7.29 (dbg), 5.7.29 (opt), 8.0.19 (dbg), 8.0.19 (opt)

MariaDB 10.4.13 works fine:

10.4.13

...
10.4.13>DELETE FROM t ORDER BY a LIMIT 1;
Query OK, 0 rows affected (0.001 sec)



 Comments   
Comment by Roel Van de Paar [ 2020-04-14 ]

A secondary testcase

USE test;
CREATE TABLE t (a INT KEY);
UPDATE t SET a=1 ORDER BY a LIMIT 1;

Asserts in a different location with same assert:

10.5.3 364e7a9ae6b5fbf69494cec30733b5ad28738cbb

mysqld: /test/10.5_dbg/sql/sql_base.cc:929: void close_thread_table(THD*, TABLE**): Assertion `!table->file->keyread_enabled()' failed.

And different stack:

10.5.3 364e7a9ae6b5fbf69494cec30733b5ad28738cbb

Core was generated by `/test/MD110420-mariadb-10.5.3-linux-x86_64-dbg/bin/mysqld --no-defaults --core-'.
Program terminated with signal SIGABRT, Aborted.
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6)
    at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
[Current thread is 1 (Thread 0x7f93ce170700 (LWP 29159))]
(gdb) bt
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6)
    at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
#1  0x0000563bb6e9721e in my_write_core (sig=sig@entry=6) at /test/10.5_dbg/mysys/stacktrace.c:518
#2  0x0000563bb663d08f in handle_fatal_signal (sig=6) at /test/10.5_dbg/sql/signal_handler.cc:329
#3  <signal handler called>
#4  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#5  0x00007f93cc8b4801 in __GI_abort () at abort.c:79
#6  0x00007f93cc8a439a in __assert_fail_base (
    fmt=0x7f93cca2b7d8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", 
    assertion=assertion@entry=0x563bb6ff9c00 "!table->file->keyread_enabled()", 
    file=file@entry=0x563bb6ff9830 "/test/10.5_dbg/sql/sql_base.cc", line=line@entry=929, 
    function=function@entry=0x563bb6ffd460 <close_thread_table(THD*, TABLE**)::__PRETTY_FUNCTION__> "void close_thread_table(THD*, TABLE**)") at assert.c:92
#7  0x00007f93cc8a4412 in __GI___assert_fail (
    assertion=assertion@entry=0x563bb6ff9c00 "!table->file->keyread_enabled()", 
    file=file@entry=0x563bb6ff9830 "/test/10.5_dbg/sql/sql_base.cc", line=line@entry=929, 
    function=function@entry=0x563bb6ffd460 <close_thread_table(THD*, TABLE**)::__PRETTY_FUNCTION__> "void close_thread_table(THD*, TABLE**)") at assert.c:101
#8  0x0000563bb630c64d in close_thread_table (thd=thd@entry=0x7f93a0015088, 
    table_ptr=table_ptr@entry=0x7f93a0015168) at /test/10.5_dbg/sql/sql_base.cc:929
#9  0x0000563bb630cc37 in close_thread_tables (thd=thd@entry=0x7f93a0015088)
    at /test/10.5_dbg/sql/sql_base.cc:915
#10 0x0000563bb639996a in mysql_execute_command (thd=thd@entry=0x7f93a0015088)
    at /test/10.5_dbg/sql/sql_parse.cc:5976
#11 0x0000563bb63a09d1 in mysql_parse (thd=thd@entry=0x7f93a0015088, rawbuf=<optimized out>, 
    length=<optimized out>, parser_state=parser_state@entry=0x7f93ce16f450, 
    is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false)
    at /test/10.5_dbg/sql/sql_parse.cc:7953
#12 0x0000563bb638c719 in dispatch_command (command=command@entry=COM_QUERY, 
    thd=thd@entry=0x7f93a0015088, 
    packet=packet@entry=0x7f93a0067089 "UPDATE t SET a=1 ORDER BY a LIMIT 1", 
    packet_length=packet_length@entry=35, is_com_multi=is_com_multi@entry=false, 
    is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:1839
#13 0x0000563bb638af6f in do_command (thd=0x7f93a0015088) at /test/10.5_dbg/sql/sql_parse.cc:1358
#14 0x0000563bb64e5a53 in do_handle_one_connection (connect=<optimized out>, 
    connect@entry=0x7f93a44433a8, put_in_cache=put_in_cache@entry=true)
    at /test/10.5_dbg/sql/sql_connect.cc:1422
#15 0x0000563bb64e5d82 in handle_one_connection (arg=arg@entry=0x7f93a44433a8)
    at /test/10.5_dbg/sql/sql_connect.cc:1319
#16 0x0000563bb6946080 in pfs_spawn_thread (arg=0x7f93cbc45888)
    at /test/10.5_dbg/storage/perfschema/pfs.cc:2201
#17 0x00007f93cd5976db in start_thread (arg=0x7f93ce170700) at pthread_create.c:463
#18 0x00007f93cc99588f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Comment by Elena Stepanova [ 2020-04-14 ]

It is the same, or closely related to, MDEV-22062, appeared after the same commit and seems to have been fixed in bb-10.5-monty branch already. However monty might want to add the test case, as the effect with temporary table is somewhat different (handler::ha_reset vs close_thread_table).

Comment by Michael Widenius [ 2020-04-20 ]

Pushed into 10.5

Generated at Thu Feb 08 09:13:14 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.