[MDEV-22193] Avoid un-necessary page initialization during recovery Created: 2020-04-08  Updated: 2020-04-09  Resolved: 2020-04-09

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.5.2
Fix Version/s: 10.5.3

Type: Bug Priority: Minor
Reporter: Thirunarayanan Balathandayuthapani Assignee: Thirunarayanan Balathandayuthapani
Resolution: Fixed Votes: 0
Labels: None


 Description   

After MDEV-22169, InnoDB could do unnecessary page initialization during recovery.
InnoDB does unnecessary traversal of redo logs during last phase.

 Comments   
Comment by Thirunarayanan Balathandayuthapani [ 2020-04-08 ]

Patch is present in bb-10.5-MDEV-22913. Please review it whenever possible.
Ran all test suites and tested with MDEV-22169 data directory

Comment by Marko Mäkelä [ 2020-04-08 ]

This looks OK to me. But I think we need broad RQG testing of recovery (kill the server, restart with a random innodb_buffer_pool_size). Normal regressions tests do not typically perform crash recovery with a smaller buffer pool size.

Comment by Matthias Leich [ 2020-04-09 ]

In RQG testing (CrashRecovery)
origin/bb-10.5-MDEV-22193 75d592800ae0109c9f3df040b0a8afe78075f2c1 2020-04-08T18:45:52+05:30
performed just as well as the actual 10.5. Both showed the same bad effects.

Generated at Thu Feb 08 09:12:53 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.