modernise Linux Large Page support (multiplesizes) (MDEV-18851)

[MDEV-22175] windows installer - create SeLockMemoryPrivilege for Service account Created: 2020-04-07  Updated: 2020-05-19  Resolved: 2020-05-18

Status: Closed
Project: MariaDB Server
Component/s: Platform Windows
Affects Version/s: 10.5.3
Fix Version/s: 10.6.0

Type: Technical task Priority: Major
Reporter: Daniel Black Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
is blocked by MDEV-22272 windows installer - run service unter... Closed

 Description   

In Windows installer sql/mysql_install_db.cc

create a `SeLockMemoryPrivilege` for the created service account

LsaAddAccountRights maybe.



 Comments   
Comment by Vladislav Vaintroub [ 2020-04-17 ]

I added MDEV-22272 as prerequisite. So far, mariadb services run under NETWORK SERVICE account. For this predefined account, that runs a lot of Windows stuff besides MariaDB, I'd hesitate to change privileges. But for virtual (per-service) accounts, this should be fine.

Comment by Daniel Black [ 2020-04-18 ]

Thank you wlad, I was fairly sure I was out of my depth to attempt this myself.

Comment by Vladislav Vaintroub [ 2020-05-18 ]

Fixed in the latest 10.6

the new parameter name is --large-pages
The MSI does not know about it yet, also, there is no autocleanup, i.e after you throw your database away, and remove the NT service, there is still a stale entry in secpol.msc, under Local Security Policy /User Rights Assignment /Lock Pages in memory. I do not know why Windows would not autoremove the privileges for the service user, associated with Windows service that was removed, but maybe we can add some --uninstall to the mysql_install_db.exe later to do better cleanup.

Comment by Daniel Black [ 2020-05-19 ]

Thank you wlad

Generated at Thu Feb 08 09:12:45 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.