[MDEV-22062] Assertion `!table->file->keyread_enabled()' failed in close_thread_table Created: 2020-03-27  Updated: 2020-04-20  Resolved: 2020-04-20

Status: Closed
Project: MariaDB Server
Component/s: Server
Affects Version/s: 10.5
Fix Version/s: 10.5.3

Type: Bug Priority: Critical
Reporter: Elena Stepanova Assignee: Michael Widenius
Resolution: Fixed Votes: 0
Labels: affects-tests, regression

Issue Links:
Relates
relates to MDEV-22077 Assertion `table->no_keyread || !tabl... Closed
relates to MDEV-22237 Assertion `!table->file->keyread_enab... Closed

 Description   

--source include/have_innodb.inc
 
CREATE TABLE t1 (a INT NOT NULL, UNIQUE(a)) ENGINE=InnoDB;
# Optional, fails with an empty table as well
INSERT INTO t1 VALUES (1),(2);
DELETE FROM t1 ORDER BY a LIMIT 1;
 
# Cleanup
DROP TABLE t1;

10.5 eb483c51

mysqld: /data/src/10.5/sql/sql_base.cc:1022: void close_thread_table(THD*, TABLE**): Assertion `!table->file->keyread_enabled()' failed.
200327 19:35:18 [ERROR] mysqld got signal 6 ;
 
#7  0x00007f2dab15ef12 in __GI___assert_fail (assertion=0x55d83faddf70 "!table->file->keyread_enabled()", file=0x55d83faddbf8 "/data/src/10.5/sql/sql_base.cc", line=1022, function=0x55d83fadfba0 <close_thread_table(THD*, TABLE**)::__PRETTY_FUNCTION__> "void close_thread_table(THD*, TABLE**)") at assert.c:101
#8  0x000055d83eca72e6 in close_thread_table (thd=0x7f2d74000b18, table_ptr=0x7f2d74000bf8) at /data/src/10.5/sql/sql_base.cc:1022
#9  0x000055d83eca71aa in close_thread_tables (thd=0x7f2d74000b18) at /data/src/10.5/sql/sql_base.cc:1008
#10 0x000055d83ed5b8be in mysql_execute_command (thd=0x7f2d74000b18) at /data/src/10.5/sql/sql_parse.cc:5976
#11 0x000055d83ed616b2 in mysql_parse (thd=0x7f2d74000b18, rawbuf=0x7f2d74013920 "DELETE FROM t1 ORDER BY a LIMIT 1", length=33, parser_state=0x7f2da46e3520, is_com_multi=false, is_next_command=false) at /data/src/10.5/sql/sql_parse.cc:7953
#12 0x000055d83ed4cf03 in dispatch_command (command=COM_QUERY, thd=0x7f2d74000b18, packet=0x7f2d74008689 "DELETE FROM t1 ORDER BY a LIMIT 1", packet_length=33, is_com_multi=false, is_next_command=false) at /data/src/10.5/sql/sql_parse.cc:1840
#13 0x000055d83ed4b639 in do_command (thd=0x7f2d74000b18) at /data/src/10.5/sql/sql_parse.cc:1359
#14 0x000055d83eeedcd5 in do_handle_one_connection (connect=0x55d8428874d8, put_in_cache=true) at /data/src/10.5/sql/sql_connect.cc:1422
#15 0x000055d83eeeda04 in handle_one_connection (arg=0x55d8428874d8) at /data/src/10.5/sql/sql_connect.cc:1319
#16 0x000055d83f4215e4 in pfs_spawn_thread (arg=0x55d8427f7e08) at /data/src/10.5/storage/perfschema/pfs.cc:2201
#17 0x00007f2dad0e74a4 in start_thread (arg=0x7f2da46e4700) at pthread_create.c:456
#18 0x00007f2dab21bd0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

No obvious effect on a non-debug build.
The failure appeared in 10.5 tree with this commit:

commit eb483c5181ab430877c135c16224284cfc517b3d
Author: Monty <monty@mariadb.org>
Date:   Fri Feb 28 12:59:30 2020 +0200
 
    Updated optimizer costs in multi_range_read_info_const() and sql_select.cc



 Comments   
Comment by Michael Widenius [ 2020-03-31 ]

I have a bug fix. Will push it together with other fixes in a few days

Comment by Roel Van de Paar [ 2020-04-08 ]

Ran into this one also.

USE test;
CREATE TABLE t (c INT KEY);
DELETE FROM t ORDER BY c LIMIT 1;

Leads to:

10.5.3 0eab87cef26eaac2cff1942e32b3c8c2a8bedf12

mysqld: /data/10.5_dbg/sql/sql_base.cc:929: void close_thread_table(THD*, TABLE**): Assertion `!table->file->keyread_enabled()' failed.

10.5.3 0eab87cef26eaac2cff1942e32b3c8c2a8bedf12

Core was generated by `/data/MD080420-mariadb-10.5.3-linux-x86_64-dbg/bin/mysqld --no-defaults --core-'.
Program terminated with signal SIGABRT, Aborted.
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6)
    at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
[Current thread is 1 (Thread 0x7fc215695700 (LWP 15345))]
(gdb) bt
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
#1  0x000055b45919bd3a in my_write_core (sig=sig@entry=6) at /data/10.5_dbg/mysys/stacktrace.c:518
#2  0x000055b458941b1b in handle_fatal_signal (sig=6) at /data/10.5_dbg/sql/signal_handler.cc:329
#3  <signal handler called>
#4  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#5  0x00007fc213dd9801 in __GI_abort () at abort.c:79
#6  0x00007fc213dc939a in __assert_fail_base (fmt=0x7fc213f507d8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x55b4592fec00 "!table->file->keyread_enabled()", file=file@entry=0x55b4592fe830 "/data/10.5_dbg/sql/sql_base.cc", line=line@entry=929, function=function@entry=0x55b459302460 <close_thread_table(THD*, TABLE**)::__PRETTY_FUNCTION__> "void close_thread_table(THD*, TABLE**)") at assert.c:92
#7  0x00007fc213dc9412 in __GI___assert_fail (assertion=assertion@entry=0x55b4592fec00 "!table->file->keyread_enabled()", file=file@entry=0x55b4592fe830 "/data/10.5_dbg/sql/sql_base.cc", line=line@entry=929, function=function@entry=0x55b459302460 <close_thread_table(THD*, TABLE**)::__PRETTY_FUNCTION__> "void close_thread_table(THD*, TABLE**)") at assert.c:101
#8  0x000055b4586114cd in close_thread_table (thd=thd@entry=0x7fc1e7c15088, table_ptr=table_ptr@entry=0x7fc1e7c15168) at /data/10.5_dbg/sql/sql_base.cc:929
#9  0x000055b458611ab7 in close_thread_tables (thd=thd@entry=0x7fc1e7c15088) at /data/10.5_dbg/sql/sql_base.cc:915
#10 0x000055b45869e7ea in mysql_execute_command (thd=thd@entry=0x7fc1e7c15088) at /data/10.5_dbg/sql/sql_parse.cc:5976
#11 0x000055b4586a5851 in mysql_parse (thd=thd@entry=0x7fc1e7c15088, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x7fc215694450, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /data/10.5_dbg/sql/sql_parse.cc:7953
#12 0x000055b458691599 in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x7fc1e7c15088, packet=packet@entry=0x7fc1e7c67089 "DELETE FROM t ORDER BY c LIMIT 1", packet_length=packet_length@entry=32, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /data/10.5_dbg/sql/sql_parse.cc:1839
#13 0x000055b45868fdef in do_command (thd=0x7fc1e7c15088) at /data/10.5_dbg/sql/sql_parse.cc:1358
#14 0x000055b4587ea8ef in do_handle_one_connection (connect=<optimized out>, connect@entry=0x7fc1ec0433a8, put_in_cache=put_in_cache@entry=true) at /data/10.5_dbg/sql/sql_connect.cc:1422
#15 0x000055b4587eac1e in handle_one_connection (arg=arg@entry=0x7fc1ec0433a8) at /data/10.5_dbg/sql/sql_connect.cc:1319
#16 0x000055b458c4acae in pfs_spawn_thread (arg=0x7fc213045888) at /data/10.5_dbg/storage/perfschema/pfs.cc:2201
#17 0x00007fc214abc6db in start_thread (arg=0x7fc215695700) at pthread_create.c:463
#18 0x00007fc213eba88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Bug confirmed present in:
MariaDB: 10.5.3 (dbg)

Bug confirmed not present in:
MariaDB: 10.1.45 (dbg), 10.1.45 (opt), 10.2.32 (dbg), 10.2.32 (opt), 10.3.23 (dbg), 10.3.23 (opt), 10.4.13 (dbg), 10.4.13 (opt), 10.5.3 (opt)
MySQL: 5.5.62 (dbg), 5.5.62 (opt), 5.6.47 (dbg), 5.6.47 (opt), 5.7.29 (dbg), 5.7.29 (opt), 8.0.19 (dbg), 8.0.19 (opt)

Comment by Michael Widenius [ 2020-04-20 ]

Pushed into 10.5

Generated at Thu Feb 08 09:11:54 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.