[MDEV-21664] Add opt files for have_innodb_Xk.inc Created: 2020-02-04  Updated: 2023-09-11  Resolved: 2023-09-11

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB, Tests
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3, 11.2.2

Type: Task Priority: Minor
Reporter: Elena Stepanova Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
is blocked by MDEV-21678 innodb_gis.gis_split_nan fails with E... Closed
is blocked by MDEV-21679 innodb_zip.index_large_prefix_4k fail... Closed

 Description   

Currently include/have_innodb_4k.inc etc. files only check that the server is running with the corresponding page size. I think it would be more convenient if they actually enforced the setting.

diff --git a/mysql-test/include/have_innodb_16k.opt b/mysql-test/include/have_innodb_16k.opt
new file mode 100644
index 00000000000..2ece0f02d02
--- /dev/null
+++ b/mysql-test/include/have_innodb_16k.opt
@@ -0,0 +1 @@
+--innodb-page-size=16k
diff --git a/mysql-test/include/have_innodb_32k.opt b/mysql-test/include/have_innodb_32k.opt
new file mode 100644
index 00000000000..cabc8fc7378
--- /dev/null
+++ b/mysql-test/include/have_innodb_32k.opt
@@ -0,0 +1 @@
+--innodb-page-size=32k
diff --git a/mysql-test/include/have_innodb_4k.opt b/mysql-test/include/have_innodb_4k.opt
new file mode 100644
index 00000000000..e5b58602036
--- /dev/null
+++ b/mysql-test/include/have_innodb_4k.opt
@@ -0,0 +1 @@
+--innodb-page-size=4k
diff --git a/mysql-test/include/have_innodb_64k.opt b/mysql-test/include/have_innodb_64k.opt
new file mode 100644
index 00000000000..c70123809fc
--- /dev/null
+++ b/mysql-test/include/have_innodb_64k.opt
@@ -0,0 +1 @@
+--innodb-page-size=64k
diff --git a/mysql-test/include/have_innodb_8k.opt b/mysql-test/include/have_innodb_8k.opt
new file mode 100644
index 00000000000..f75efe9af79
--- /dev/null
+++ b/mysql-test/include/have_innodb_8k.opt
@@ -0,0 +1 @@
+--innodb-page-size=8k



 Comments   
Comment by Elena Stepanova [ 2020-02-06 ]

Blocked by the linked flawed tests.

Comment by Elena Stepanova [ 2022-03-14 ]

It still hasn't been done, and I still think it's a reasonable thing to do, but I'll leave it to the InnoDB team to decide.

Comment by Marko Mäkelä [ 2023-09-11 ]

I am sorry for the delay. I reassigned MDEV-21678 back to me, analyzed and closed it in order to unblock this.

Generated at Thu Feb 08 09:08:52 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.