[MDEV-21587] Regression since 10.1.44 release: test disks_notembedded fails in Ubuntu 18.04 (still affect 11.0) Created: 2020-01-29  Updated: 2023-12-12  Resolved: 2023-12-12

Status: Closed
Project: MariaDB Server
Component/s: Plugins, Tests
Affects Version/s: 10.1.44, 11.0
Fix Version/s: 10.4.33, 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3

Type: Bug Priority: Minor
Reporter: Otto Kekäläinen Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Blocks
blocks MDBF-155 Test running (almost) all tests on al... Closed

 Description   

While importing latest MariaDB 10.1.44 and doing test builds before upload to Ubuntu 18.04 I noticed all builds failed at https://launchpad.net/~mysql-ubuntu/+archive/ubuntu/mariadb-10.1/+builds?build_text=&build_state=all

disks.disks_notembedded                  w1 [ fail ]
 
        Test ended at 2020-01-29 08:05:53
 
 
 
CURRENT_TEST: disks.disks_notembedded
 
--- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.result	2020-01-25 21:54:37.000000000 +0000
 
+++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.reject	2020-01-29 08:05:52.909814219 +0000
 
@@ -10,6 +10,6 @@
 
 GRANT FILE ON *.* TO user1@localhost;
 
 select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
 
 sum(Total) > sum(Available)	sum(Total)>sum(Used)
 
-1	1
 
+NULL	NULL
 
 DROP USER user1@localhost;
 
 # End of 10.1 tests
 
 
 
mysqltest: Result length mismatch

Full log at https://launchpadlibrarian.net/462586124/buildlog_ubuntu-bionic-amd64.mariadb-10.1_1%3A10.1.44-0ubuntu0.18.04.1~ubuntu18.04.1~1580282784.5039329b84_BUILDING.txt.gz

Since exactly same failure happened on all platforms, it is certainly not a sporadic failure.

I would either need a patch for this failure I can add on top of 10.1.44 sources (at https://salsa.debian.org/mariadb-team/mariadb-10.1/tree/ubuntu-18.04) or somebody to acknowledge that this error is safe to ignore.

 Comments   
Comment by Elena Stepanova [ 2020-01-29 ]

We've never had this failure in buildbot, so it must be something environment- or build-related. sanja, could you please take a look?

Comment by Otto Kekäläinen [ 2020-01-29 ]

If this test is not important, maybe I should update in Ubuntu 18.04 release chain that mtr only runs `--skip-rpl --suite=main` so less important tests don't even get run.

Comment by Otto Kekäläinen [ 2020-01-30 ]

As a side note, I did a test build with 10.3.22 on Launchpad with all regular tests enabled `/mysql-test-run.pl --force --testcase-timeout=30 --suite-timeout=540 --retry=3 --parallel=4`.

If bailed out with `Too many failed: Failed 8/1688 tests, 99.53% were successful.` before it got to running `

Failing test(s): tokudb_bugs.mdev4533 tokudb.type_varchar tokudb_mariadb.xa-recovery-9214 tokudb_bugs.db811 tokudb_bugs.db811s tokudb.ext_key_1_innodb tokudb_bugs.2970i tokudb.simple_join_tokudb_innodb

Full log at https://launchpadlibrarian.net/462670463/buildlog_ubuntu-focal-amd64.mariadb-10.3_1%3A10.3.22-1~ubuntu20.04.1~1580309012.6774686bb_BUILDING.txt.gz

The arm64 build (that does not have TokuDB) ran all tests and ended with:

Completed: Failed 2/4913 tests, 99.96% were successful.
 
 
 
Failing test(s): disks.disks_notembedded unit.conc_connection

Full logt at https://launchpadlibrarian.net/462674095/buildlog_ubuntu-focal-arm64.mariadb-10.3_1%3A10.3.22-1~ubuntu20.04.1~1580309012.6774686bb_BUILDING.txt.gz

So this issue seems to apply to mariadb-10.3 series as well.

Comment by Otto Kekäläinen [ 2020-01-30 ]

Fixed for Ubuntu 18.04 upload via limiting scope of tests in https://salsa.debian.org/mariadb-team/mariadb-10.1/commit/321840af94a5e1342694542031cffa780e2f9678

Comment by Otto Kekäläinen [ 2020-10-12 ]

Tested with an upload to Launchpad where the extended test suite is enabled. However the test seems to be globally disabled, so it didn't run at all:

disks.disks_notembedded                  [ disabled ]  MDEV-21587 - Wrong result

Log: https://launchpadlibrarian.net/501650715/buildlog_ubuntu-groovy-s390x.mariadb-10.5_1%3A10.5.5-4~ubuntu20.10.1~1602458170.84f9c0e86.master.next_BUILDING.txt.gz

Comment by Otto Kekäläinen [ 2020-10-12 ]

I enabled it, and it is still failing:

disks.disks_notembedded                  w2 [ fail ]
 
        Test ended at 2020-10-12 09:17:52
 
 
 
CURRENT_TEST: disks.disks_notembedded
 
--- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.result	2020-08-07 12:57:37.000000000 +0000
 
+++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.reject	2020-10-12 09:17:52.083471238 +0000
 
@@ -16,7 +16,7 @@
 
 connection con1;
 
 select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
 
 sum(Total) > sum(Available)	sum(Total)>sum(Used)
 
-1	1
 
+NULL	NULL
 
 connection default;
 
 DROP USER user1@localhost;
 
 # End of 10.1 tests

https://launchpadlibrarian.net/501710274/buildlog_ubuntu-groovy-amd64.mariadb-10.5_1%3A10.5.5-4~ubuntu20.10.1~1602488010.9ccdf6955.master.next_BUILDING.txt.gz

Comment by Otto Kekäläinen [ 2023-03-20 ]

Almost the same issue still affects latest MariaDB. See log https://launchpadlibrarian.net/656676218/buildlog_ubuntu-lunar-amd64.mariadb_1%3A10.11.2-2~ubuntu23.04.1~1679260930.3d164ca5277.dev.otto_BUILDING.txt.gz

disks.disks                              w3 [ fail ]
 
        Test ended at 2023-03-19 22:24:41
 
 
 
CURRENT_TEST: disks.disks
 
--- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.result	2023-02-01 17:28:03.000000000 +0000
 
+++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.reject	2023-03-19 22:24:40.957776210 +0000
 
@@ -9,4 +9,4 @@
 
 ) ENGINE=MEMORY DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci
 
 select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
 
 sum(Total) > sum(Available)	sum(Total)>sum(Used)
 
-1	1
 
+0	1
 
 
 
 
 
disks.disks_notembedded                  w3 [ fail ]
 
        Test ended at 2023-03-19 22:24:41
 
 
 
CURRENT_TEST: disks.disks_notembedded
 
--- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.result	2023-02-01 17:28:03.000000000 +0000
 
+++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks_notembedded.reject	2023-03-19 22:24:41.513783805 +0000
 
@@ -16,7 +16,7 @@
 
 connection con1;
 
 select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
 
 sum(Total) > sum(Available)	sum(Total)>sum(Used)
 
-1	1
 
+0	1
 
 connection default;
 
 DROP USER user1@localhost;
 
 # End of 10.1 tests
 
 
 
mysqltest: Result content mismatch

Comment by Daniel Black [ 2023-03-22 ]

Might be that Sum(Total) = sum(Available) because of very large values of Total and low values of Used.

> -> >= might solve it.

NULL would be no storage found. Implementation changes significantly in https://github.com/MariaDB/server/pull/2216 (MDEV-28592 / MDEV-27818) see commit details. Might be it cannot reasonably occur in ci situtations.

Comment by Otto Kekäläinen [ 2023-10-05 ]

I just ran the full official test suite and these disk.disks and disk.disks_notembedded are still failing (log https://launchpadlibrarian.net/690458994/buildlog_ubuntu-mantic-amd64.mariadb_1%3A10.11.5-2~bpo23.10.1~1696482175.fcfd3a06fd5.debian.latest.full.mariadb.test.run_BUILDING.txt.gz)

disks.disks                              w1 [ fail ]
 
        Test ended at 2023-10-05 06:01:49
 
 
 
CURRENT_TEST: disks.disks
 
--- /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.result	2023-08-11 06:35:40.000000000 +0000
 
+++ /<<PKGBUILDDIR>>/plugin/disks/mysql-test/disks/disks.reject	2023-10-05 06:01:49.380731316 +0000
 
@@ -9,4 +9,4 @@
 
 ) ENGINE=MEMORY DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci
 
 select sum(Total) > sum(Available), sum(Total)>sum(Used) from information_schema.disks;
 
 sum(Total) > sum(Available)	sum(Total)>sum(Used)
 
-1	1
 
+0	1
 
 
 
mysqltest: Result content mismatch

Comment by Daniel Black [ 2023-10-05 ]

for large values of storage, available=total due to rounding. Need to change the test to:

 sum(Total) >= sum(Available)

Comment by Otto Kekäläinen [ 2023-10-07 ]

I can confirm that disks.disks is now fixed thanks to https://github.com/MariaDB/server/pull/2777, but not yet disks.disks_notembedded.

Generated at Thu Feb 08 09:08:16 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.