So your point is if --defaults-file= =/tmp/my.cnf is supplied than output should be dynamically changed (or appended to previous /etc/my.cnf ~/.my.cnf):

Default options are read from the following files in the given order:

/tmp/my.cnf

right ?
In this situation we should check defaults-file (extra_opt variable ?) and if exist conf_file should be changed from MYSQL_CONFIG_NAME to argument of defaults-file in function print_defaults().

Isn't the current situation self explanatory?
Meaning, rule of thumb are default options in given order + bellow there is option --default-file which is explaining what it should do, if one would like to use it.
Than those will not be default options, but custom options.

Hi anel,

So your point is if --defaults-file= =/tmp/my.cnf is supplied than output should be dynamically changed ?

Yes, exactly. The output is already changed dynamically in several cases. We just need to fix it so that it is also changed dynamically in the case that the --defaults-file option is set.

For example, here's normal output:

$ mysql --help --verbose

...

Default options are read from the following files in the given order:

/etc/my.cnf ~/.my.cnf

And if you set the --defaults-extra-file option, then the output changes to this:

$ mysql --defaults-extra-file=/etc/my_extra.cnf --help --verbose

...

Default options are read from the following files in the given order:

/etc/my.cnf /etc/my_extra.cnf/my.cnf ~/.my.cnf

And if you set the $MYSQL_HOME environment variable, then the output changes to this:

$ export MYSQL_HOME=/mysql

$ mysql --help --verbose

...

Default options are read from the following files in the given order:

/etc/my.cnf /mysql/my.cnf ~/.my.cnf

Additionally, the -help --verbose output also changes if the -defaults-group-suffix option is set:

$ mysql --defaults-group-suffix=_server1 --help --verbose

...

The following groups are read: mysql mariadb-client client client-server client-mariadb mysql_server1 mariadb-client_server1 client_server1 client-server_server1 client-mariadb_server1

...

And the output also changes if the $MYSQL_GROUP_SUFFIX environment variable is set:

$ export MYSQL_GROUP_SUFFIX=_server1

$ mysql --help --verbose

...

The following groups are read: mysql mariadb-client client client-server client-mariadb mysql_server1 mariadb-client_server1 client_server1 client-server_server1 client-mariadb_server1

...

Hi GeoffMontee,
thanks, I think it is good idea to show only the file which is used in case defaults-file without appending to other global configs.
What about no-defaults only, I think we should probably change the message here too saying that there is no supplied config file in help verbose?!

Hi anel,

That kind of change in behavior sounds like it would make it consistent to me.

Hi GeoffMontee,
after the patch is applied here are the outputs:

$ ./sql/mysqld --defaults-file=/home/anel/my_10.1.cnf --help --verbose | less

Default options are read from the following files in the given order:

/home/anel/my_10.1.cnf

Also the patch is fixing case for defaults-file-extra, where the file is translated to directory and my.cnf is appended, so it was:

$ ./sql/mysqld --defaults-extra-file=/home/anel/my_10.1.cnf --help --verbose | less

Default options are read from the following files in the given order:

/etc/my.cnf /etc/mysql/my.cnf /home/anel/my_10.1.cnf/my.cnf ~/.my.cnf 

# With patch we are just using file name:

# Default options are read from the following files in the given order:

/etc/my.cnf /etc/mysql/my.cnf /home/anel/my_10.1.cnf ~/.my.cnf 

right?
For --no-format , there is no variable defined for that, except that we now it has to be first in queue to have a impact and a lot of prototypes should be changed, so I didn't want to change that.

Hi anel,

Looks good to me!

Ok to push

Pushed with b9689712e