[MDEV-21360] global debug_dbug pre-test value restoration issues Created: 2019-12-19 Updated: 2023-11-27 Resolved: 2020-01-23 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Tests |
| Affects Version/s: | 10.1, 10.2, 10.3, 10.4, 10.5 |
| Fix Version/s: | 10.2.31, 10.3.22, 10.4.12 |
| Type: | Bug | Priority: | Major |
| Reporter: | Andrei Elkin | Assignee: | Alice Sherepa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | dbug | ||
| Description |
|
There are two failure-prone pattern in mtr suite tests that allows for a pre-test 1. Total reset of @@global.debug_dbug at the end of the test, like in
when run with a pre-installed debug_dbug: ./mtr --mysqld = --debug=d,.... 2. reset to a "$saved" mtr variable that expands at the assignment
to a string whose value is actually variable Resetting should be done either via save/restore through a session @var, see
or instead of the memorization pattern a +/-d,keyword increment and decrement style should be used. |
| Comments |
| Comment by Sergei Golubchik [ 2019-12-19 ] |
|
"+/-d,keyword increment and decrement style" cannot be used until MDEV-21361 is fixed. It's safer to restore from @old_dbug |
| Comment by Sujatha Sivakumar (Inactive) [ 2020-01-20 ] |
|
Thank you for working on this Alice. The changes look good. |