[MDEV-21303] Make executables MariaDB named Created: 2019-12-12  Updated: 2024-01-23  Resolved: 2020-03-23

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: 10.5.2

Type: Task Priority: Critical
Reporter: Rasmus Johansson (Inactive) Assignee: Rasmus Johansson (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Problem/Incident
causes MDEV-22003 mysql_config disappeared from 10.5 (e... Closed
causes MDEV-22009 main.mysqlhotcopy_myisam cannot find ... Closed
causes MDEV-22010 use executables MariaDB named in scripts Closed
causes MDEV-22023 fix manpages to use mariadb* executab... Open
causes MDEV-22214 Windows: crash when mariadbd.exe tri... Closed
causes MDEV-22569 Startup scripts in 10.5 still start "... Closed
causes MDEV-29615 mtr to use mariadb names Closed
Relates
relates to MDEV-17591 Create MariaDB named commands Closed
relates to MDEV-21298 mariabackup doesn't read from the [ma... Closed
relates to MDEV-21301 mariabackup doesn't read [mariadb-bac... Closed
relates to MDEV-29614 mariadb-upgrade calls mysql and mysql... Closed
relates to MDEV-30276 wsrep_sst_mariabackup to use mariadb-... Closed
relates to MDEV-17812 Use MariaDB in error messages instead... Closed
relates to MDEV-30275 mariadb names rather than mysql names... Closed

 Description   

In 10.4 mariadb named symlinks were added to make it possible to run the the tools for MariaDB. For example instead of writing mysql to start the client one can write mariadb, or mariadb-dump instead of mysqldump. More details on what was done in 10.4 can be found in the task MDEV-17591.

In 10.5 we're taking the next step and flipping the logic, i.e. so that the binaries will actually be named mariadb-something and there will be a symlink for the corresponding mysql command.

 Comments   
Comment by Otto Kekäläinen [ 2020-03-14 ]

ratzpo This involves a lot of Debian packaging changes. I can already see some issues in draft at https://github.com/MariaDB/server/commit/2dd1b86fb6e7c25eb3ed9c370afa08ece5e871c5. I am happy to take part in reviewing and testing this once you are done.

Comment by Rasmus Johansson (Inactive) [ 2020-03-15 ]

ottoI'm pretty much done in commit https://github.com/MariaDB/server/commit/4e6249bd72d0414ef97d6ad733613229a46e71f3 . There were a lot of upgrade failures related to Debian, where I had moved things from the server package to the client. I think I sorted it out though. But please review and test. Thanks!

Comment by Otto Kekäläinen [ 2020-03-15 ]

Looking.. First of all the commit message does not make much sense. I hope it is work-in-progress and not the final one. There is also the removal of `usr/lib/mysql/plugin/ha_sphinx.so` that is not mentioned in the commit message.

If you run `wrap-and-sort -a -v` the file lists will automatically be in correct order, extra whitespace is removed etc.

Do you plan to finally make a proper pull request out of this so it can be reviewed properly?

Comment by Rasmus Johansson (Inactive) [ 2020-03-16 ]

otto here is a pull request for this change https://github.com/MariaDB/server/pull/1465 .

Comment by Geoff Montee (Inactive) [ 2020-04-08 ]

MDEV-21298 and MDEV-21301 are both related to this too.

Comment by Geoff Montee (Inactive) [ 2020-05-14 ]

MDEV-22569 is also related to this.

Generated at Thu Feb 08 09:06:07 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.