[MDEV-21158] trx_undo_seg_free() is never redo-logged Created: 2019-11-27  Updated: 2019-11-27  Resolved: 2019-11-27

Status: Closed
Project: MariaDB Server
Component/s: mariabackup, Storage Engine - InnoDB
Affects Version/s: 10.3.1, 10.4.0
Fix Version/s: 10.3.21, 10.4.11

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: backup, recovery

Issue Links:
Problem/Incident
is caused by MDEV-12288 Reset DB_TRX_ID when the history is r... Closed

 Description   

As part of MDEV-12288, a parameter of trx_undo_commit_cleanup() was accidentally always passed as bool noredo=true.

The impact of this should be that some undo log pages may not be correctly freed if the server is killed and crash recovery will be performed. Similarly, if mariabackup --backup is being executed concurrently with user transaction commits, it could happen that some undo log pages in the backup will never be marked as free for reuse.

As far as I can tell, this bug should not have any user-visible impact other than some undo pages being wasted. I found the bug when working on code refactoring.


Generated at Thu Feb 08 09:05:01 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.