[MDEV-20859] rocksdb.drop_table2 test takes a lot of time Created: 2019-10-18  Updated: 2023-04-27

Status: Open
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Affects Version/s: 10.2, 10.3, 10.4
Fix Version/s: 10.4

Type: Bug Priority: Major
Reporter: Sergei Petrunia Assignee: Sergei Petrunia
Resolution: Unresolved Votes: 0
Labels: None


 Description   

rocksdb.drop_table2 takes nearly a minute to run. On a debug build:

rocksdb.drop_table2 'write_committed'    [ pass ]  90926
 
rocksdb.drop_table2 'write_prepared'     [ pass ]  92987

Does it really spend 1.5 minutes doing something useful?

 Comments   
Comment by Sergei Petrunia [ 2019-10-18 ]

It includes drop_table_repopulate_table.inc which does line-by-line INSERTs. Switching to sequence engine helps a bit:

rocksdb.drop_table2 'write_committed'    [ pass ]  76029
 
rocksdb.drop_table2 'write_prepared'     [ pass ]  76382

but not much

Comment by Sergei Petrunia [ 2019-10-18 ]

Most of the time (one minute) is actually spent in the final wait here:

set @@global.rocksdb_compact_cf = 'cf1';
 
set @@global.rocksdb_compact_cf = 'rev:cf2';
 
set @@global.rocksdb_compact_cf = 'default';
 
 
 
let $show_rpl_debug_info= 1; # to force post-failure printout
 
let $wait_timeout= 300; # Override default 30 seconds with 300.
 
let $wait_condition = select count(*) = 0 
                      as c from information_schema.rocksdb_global_info
 
                      where TYPE = 'DDL_DROP_INDEX_ONGOING';
 
--source include/wait_condition.inc

Comment by Sergei Petrunia [ 2019-10-18 ]

It's the same in upstream. I am not sure if the fact that DDL_DROP_INDEX_ONGOING records are not gone after 1 minute can be considered a bug?

Generated at Thu Feb 08 09:02:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.