[MDEV-20322] rocksdb doesn't free memory on shutdown Created: 2019-08-12  Updated: 2023-04-27

Status: Open
Project: MariaDB Server
Component/s: Storage Engine - RocksDB
Affects Version/s: 10.2, 10.3, 10.4, 10.5
Fix Version/s: 10.4, 10.5

Type: Bug Priority: Major
Reporter: Michael Widenius Assignee: Sergei Petrunia
Resolution: Unresolved Votes: 0
Labels: None
Environment:

BUILD/compile-pentium64-valgrind-max


Issue Links:
Duplicate
duplicates MDEV-12445 Rocksdb does not shutdown worker thre... Open
PartOf
is part of MDEV-20310 valgrind bugs found in 10.5 Open
Relates
relates to MDEV-20315 MyRocks tests produce valgrind failures Closed

 Description   

When running tests with valgrind, one gets a lot of warnings about not freed memory.
The solution by Facebook is to add suppression, but that is likely to hide bugs and doesn't work with all memory checking tools, so we should not use this approach but instead try to fix this properly by freeing all memory at plugin unload or at least during shutdown.

I am adding temporary valgrind suppression for all the issues in 10.5 until this is fixed to be able to run valgrind on the full test suite.

Example:

mtr --valgrind mariabackup.xb_rocksdb



 Comments   
Comment by Michael Widenius [ 2019-08-20 ]

Until this is fixed, we are going to use valgrind suppressions to hide the issue in 10.5 (so that we can run valgrind in buildbot)

Comment by Marko Mäkelä [ 2020-09-07 ]

As part of fixing the leaks, also the my_disable_leak_check work-around should be removed.

Comment by Marko Mäkelä [ 2020-09-07 ]

This report seems to duplicate MDEV-12445.

Generated at Thu Feb 08 08:58:35 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.