[MDEV-20321] TokuDB debug printed in prod log Created: 2019-08-12  Updated: 2019-08-12

Status: Open
Project: MariaDB Server
Component/s: Storage Engine - TokuDB
Affects Version/s: 10.2
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: jocelyn fournier Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None


 Description   

Hi,

When a server containing TokuDB tables is shutdown, debug stuff is logged:

24590 /home/buildbot/buildbot/build/mariadb-10.2.26/storage/tokudb/ha_tokudb.cc:161 static_destroy _open_tables ./optizy_saas/planning 0x7f0511798008
24590 /home/buildbot/buildbot/build/mariadb-10.2.26/storage/tokudb/ha_tokudb.cc:161 static_destroy _open_tables ./optizy_saas/script_stats 0x7f050bee7008
24590 /home/buildbot/buildbot/build/mariadb-10.2.26/storage/tokudb/ha_tokudb.cc:161 static_destroy _open_tables ./optizy_saas/server_stats 0x7f050bf81008

There's indeed no check for debug in the code:

TOKUDB_TRACE("_open_tables %s %p", it->first.c_str(), it->second);

I would have expected:

if (TOKUDB_UNLIKELY(tokudb::sysvars::debug))
TOKUDB_TRACE("_open_tables %s %p", it->first.c_str(), it->second);

instead

BR,
Jocelyn
Generated at Thu Feb 08 08:58:34 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.