[MDEV-20119] Implement the --do-domain-ids, --ignore-domain-ids, and --ignore-server-ids options for mysqlbinlog Created: 2019-07-22  Updated: 2023-09-07  Resolved: 2022-04-19

Status: Closed
Project: MariaDB Server
Component/s: Replication, Scripts & Clients
Fix Version/s: 10.9.1

Type: Task Priority: Critical
Reporter: Geoff Montee (Inactive) Assignee: Brandon Nesterenko
Resolution: Fixed Votes: 1
Labels: Preview_10.9, gtid, mysqlbinlog, replication

Issue Links:
PartOf
is part of MDEV-28112 prepare 10.9.0 preview releases Closed
Relates
relates to MDEV-4989 Support for GTID in mysqlbinlog Closed
relates to MDEV-22905 Support DO_DOMAIN_IDS and IGNORE_DOMA... Closed
relates to MXS-2581 Support DO_DOMAIN_IDS and IGNORE_DOMA... Closed
relates to MXS-2589 Adapt binlog router to Closed

 Description   

In addition to the features requested in MDEV-4989, it would also be helpful to filter GTIDs based on specific gtid_domain_id values when using mysqlbinlog. To do this, mysqlbinlog could have the --do-domain-ids, --ignore-domain-ids, and --ignore-server-ids options, which would be similar to the DO_DOMAIN_IDS, IGNORE_DOMAIN_IDS, and IGNORE_SERVER_IDS options available for CHANGE MASTER TO.

https://mariadb.com/kb/en/library/change-master-to/#do_domain_ids

https://mariadb.com/kb/en/library/change-master-to/#ignore_domain_ids

https://mariadb.com/kb/en/library/change-master-to/#ignore_server_ids

From the commit message:
"For completeness, this patch additionally adds the option --do-server-ids as an alias for
--server-id, which now accepts a list of server ids instead of a
single one."

 Comments   
Comment by Brandon Nesterenko [ 2021-08-27 ]

Hi Andrei,

This relies on some ground-work laid by MDEV-4989, so it pends your review of that, but it is good for review otherwise.

Commit: 85214cb4f7386bf10aa20fa7d97c2a46cb926001

Buildbot: bb-10.7-MDEV-20119

Comment by Brandon Nesterenko [ 2021-11-08 ]

Changing status back to in progress to update with MDEV-4989 comments.

Comment by Brandon Nesterenko [ 2022-02-16 ]

Hi Andrei! This is ready for review

Commit: b8e3790bd5f9ee
BB: bb-10.9-MDEV-20119

Edit: Updated commit to account for gtid-strict-mode fixes

Comment by Angelique Sklavounos (Inactive) [ 2022-04-15 ]

OK to push.

Comment by Brandon Nesterenko [ 2022-04-19 ]

Final commit: c132bce

Generated at Thu Feb 08 08:56:58 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.