[MDEV-20040] OOM error should always be logged to error.log Created: 2019-07-10 Updated: 2019-07-11 |
|
| Status: | Open |
| Project: | MariaDB Server |
| Component/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Minor |
| Reporter: | Aleksey Midenkov | Assignee: | Aleksey Midenkov |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Description |
|
my_error() and my_message() calls with ER_OUT_OF_RESOURCES must contain ME_ERROR_LOG in flags. Writing to error log file may fail itself, but it will be attempted at least. |
| Comments |
| Comment by Aleksey Midenkov [ 2019-07-11 ] |
|
From chat: I tend to disagree with "always". I'd say that my_malloc should mostly be invoked with MY_WME — this will log OOM into the error log. But mostly doesn't mean always. And upper layer that does ER_OUT_OF_RESOURCES or ER_OUT_OF_SORTMEMORY doesn't necessarily need to go to the error log |