[MDEV-19846] mariadb-10.4.6/plugin/auth_pam/auth_pam.c:104]: (style) Suspicious condition Created: 2019-06-24 Updated: 2019-08-22 Resolved: 2019-08-22 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Plugin - pam |
| Affects Version/s: | 10.4 |
| Fix Version/s: | 10.4.7 |
| Type: | Bug | Priority: | Major |
| Reporter: | David Binderman | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
mariadb-10.4.6/plugin/auth_pam/auth_pam.c:104]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((pkt_len= vio->read_packet(vio, &pkt) < 0)) Maybe better code: if ((pkt_len = vio->read_packet(vio, &pkt)) < 0) |