[MDEV-19643] Invalid #ifndef WINDOWS causes error because of needless "Semisync slave socket fd" check Created: 2019-05-30 Updated: 2019-06-21 Resolved: 2019-06-21 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Affects Version/s: | 10.3.13, 10.3.14, 10.3.15 |
| Fix Version/s: | 10.3.17, 10.4.7 |
| Type: | Bug | Priority: | Major |
| Reporter: | Kentaro Hayashi | Assignee: | Vladislav Vaintroub |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Windows |
||
| Description |
|
On Windows, sometimes slave stops unexpectedlly. log shows the following error. > 2019-05-30 3:21:55 6 [ERROR] Semisync slave socket fd is 580. select() Searched MariaDB implementation, above log message is printed here.
It seems that #ifndef WINDOWS is incorrect, it should be _WIN32. It seems that master can't receive ack from slave, slave waits until master response, then it causes timeout and disconnect connection.(maybe) In contrast to MySQL case, it uses _WIN32.
|
| Comments |
| Comment by Kouhei Sutou [ 2019-05-31 ] |
|
FYI: MySQL fixed this by https://github.com/mysql/mysql-server/commit/ec76a52483c3eec49a878e751341246be66a6802 . |