[MDEV-19354] Rename Windows service name to MariaDB Created: 2019-04-29 Updated: 2019-04-29 Resolved: 2019-04-29 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Packaging, Platform Windows |
| Fix Version/s: | 10.4.5 |
| Type: | Task | Priority: | Major |
| Reporter: | Geoff Montee (Inactive) | Assignee: | Vladislav Vaintroub |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||
| Description |
|
The Windows service name is still MySQL: https://github.com/MariaDB/server/blob/mariadb-10.4.4/win/packaging/extra.wxs.in#L282 https://github.com/MariaDB/server/blob/mariadb-10.4.4/include/mysql_com.h#L97 https://github.com/MariaDB/server/blob/mariadb-10.4.4/win/packaging/ca/CustomAction.cpp#L358 Should we change it to MariaDB? |
| Comments |
| Comment by Vladislav Vaintroub [ 2019-04-29 ] |
|
I would like to reduce the scope of the change to only "default name in MSI installer GUI". changing this line https://github.com/MariaDB/server/blob/mariadb-10.4.4/include/mysql_com.h#L97 could be a breaking change, something that used to work before, would not work in the future . In 10.5 , I would like to remove the self-registration via "mysqld --install", "mysqld --remove", and also the behaviour described in previous sentence (i.e I would not like to perform magic lookup for the MySQL or MariaDB service, or any service, if mysqld was not definitely registered as service) |
| Comment by Vladislav Vaintroub [ 2019-04-29 ] |
|
I hope to get rid of MYSQL_SERVICENAME completely in 10.5 with MDEV-19358. |