[MDEV-19117] Don't keep binary log index file locked during show binary logs Created: 2019-04-01 Updated: 2020-05-14 Due: 2019-04-01 Resolved: 2019-04-02 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Fix Version/s: | 10.4.4 |
| Type: | Task | Priority: | Major |
| Reporter: | Michael Widenius | Assignee: | Michael Widenius |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Description |
|
While doing show binary logs, the index_file mutex is kept locked during the reading of the index file and while calculating the length of each binary file. On some systems with 10,000+ binlogs, show binary logs could block log rotation for more than 10 seconds. When this happens, the server is locked for commits during the binary log rotation. The fix is to not keep the mutex locked while calculating the file sizes. |
| Comments |
| Comment by Michael Widenius [ 2019-04-02 ] |
|
Pushed |