[MDEV-19011] Assertion `file->s->base.reclength < file->s->vreclength' failed in ha_myisam::setup_vcols_for_repair Created: 2019-03-21  Updated: 2022-09-10  Resolved: 2021-04-27

Status: Closed
Project: MariaDB Server
Component/s: Admin statements, Storage Engine - MyISAM, Virtual Columns
Affects Version/s: 10.2, 10.3, 10.4, 10.5
Fix Version/s: 10.2.38, 10.3.29, 10.4.19, 10.5.10

Type: Bug Priority: Critical
Reporter: Elena Stepanova Assignee: Nikita Malyavin
Resolution: Fixed Votes: 0
Labels: affects-tests, crash_repair_table, not-10.1

Issue Links:
Problem/Incident
is caused by MDEV-371 Unique indexes for blobs Closed
Relates
relates to MDEV-17153 server crash on repair table ... use_frm Closed
relates to MDEV-26035 Assertion `file->s->base.reclength < ... Confirmed
relates to MDEV-28190 sql_mode makes MDEV-371 virtual colum... Closed
relates to MDEV-28514 Assertion `file->s->base.reclength < ... Confirmed

 Description    

CREATE TABLE t1 (a INT GENERATED ALWAYS AS (1) VIRTUAL) ENGINE=MyISAM;
 
ALTER TABLE t1 ADD KEY (a);
 
 
 
# Cleanup
 
DROP TABLE t1;

10.4 de51acd0

 
mysqld: /data/src/10.4/storage/myisam/ha_myisam.cc:974: void ha_myisam::setup_vcols_for_repair(HA_CHECK*): Assertion `file->s->base.reclength < file->s->vreclength' failed.
 
190321 16:36:08 [ERROR] mysqld got signal 6 ;
 
 
 
#7  0x00007fb43d947ee2 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
 
#8  0x000055e6766d4710 in ha_myisam::setup_vcols_for_repair (this=0x7fb41c14c858, param=0x7fb41c043378) at /data/src/10.4/storage/myisam/ha_myisam.cc:974
 
#9  0x000055e6766d6cc0 in ha_myisam::enable_indexes (this=0x7fb41c14c858, mode=2) at /data/src/10.4/storage/myisam/ha_myisam.cc:1642
 
#10 0x000055e6766d71d6 in ha_myisam::end_bulk_insert (this=0x7fb41c14c858) at /data/src/10.4/storage/myisam/ha_myisam.cc:1805
 
#11 0x000055e675c4b011 in handler::ha_end_bulk_insert (this=0x7fb41c14c858) at /data/src/10.4/sql/handler.h:3281
 
#12 0x000055e675d75c76 in copy_data_between_tables (thd=0x7fb41c000b00, from=0x7fb41c13c350, to=0x7fb41c14b590, create=..., ignore=false, order_num=0, order=0x0, copied=0x7fb4382bf698, deleted=0x7fb4382bf6a0, keys_onoff=Alter_info::LEAVE_AS_IS, alter_ctx=0x7fb4382c00e0) at /data/src/10.4/sql/sql_table.cc:10729
 
#13 0x000055e675d7388f in mysql_alter_table (thd=0x7fb41c000b00, new_db=0x7fb41c005298, new_name=0x7fb41c005698, create_info=0x7fb4382c0cd0, table_list=0x7fb41c0156d0, alter_info=0x7fb4382c0c10, order_num=0, order=0x0, ignore=false) at /data/src/10.4/sql/sql_table.cc:10085
 
#14 0x000055e675e0489c in Sql_cmd_alter_table::execute (this=0x7fb41c015e48, thd=0x7fb41c000b00) at /data/src/10.4/sql/sql_alter.cc:499
 
#15 0x000055e675c9258c in mysql_execute_command (thd=0x7fb41c000b00) at /data/src/10.4/sql/sql_parse.cc:6394
 
#16 0x000055e675c97725 in mysql_parse (thd=0x7fb41c000b00, rawbuf=0x7fb41c0155e8 "ALTER TABLE t1 ADD KEY (a)", length=26, parser_state=0x7fb4382c2180, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:8205
 
#17 0x000055e675c82d55 in dispatch_command (command=COM_QUERY, thd=0x7fb41c000b00, packet=0x7fb41c00a8a1 "", packet_length=26, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:1829
 
#18 0x000055e675c8153b in do_command (thd=0x7fb41c000b00) at /data/src/10.4/sql/sql_parse.cc:1358
 
#19 0x000055e675dfb445 in do_handle_one_connection (connect=0x55e679b9d4e0) at /data/src/10.4/sql/sql_connect.cc:1399
 
#20 0x000055e675dfb1b6 in handle_one_connection (arg=0x55e679b9d4e0) at /data/src/10.4/sql/sql_connect.cc:1302
 
#21 0x000055e6762f0f7f in pfs_spawn_thread (arg=0x55e679c8f8d0) at /data/src/10.4/storage/perfschema/pfs.cc:1862
 
#22 0x00007fb43f836494 in start_thread (arg=0x7fb4382c3700) at pthread_create.c:333
 
#23 0x00007fb43da0493f in clone () from /lib/x86_64-linux-gnu/libc.so.6



 Comments   
Comment by Roel Van de Paar [ 2020-07-22 ] 

USE test;
 
CREATE TABLE t(a POINT GENERATED ALWAYS AS (POINT(1,1)) VIRTUAL, UNIQUE INDEX i(a(1))) ENGINE=MyISAM;
 
REPAIR LOCAL TABLE t;

Leads to:

10.5.5 30e7a0a866dce530d8328c6d614e48d39a264f9b (Debug)

 
mysqld: /test/10.5_dbg/storage/myisam/ha_myisam.cc:976: void ha_myisam::setup_vcols_for_repair(HA_CHECK*): Assertion `file->s->base.reclength < file->s->vreclength' failed.

10.5.5 30e7a0a866dce530d8328c6d614e48d39a264f9b (Debug)

 
Core was generated by `/test/MD140720-mariadb-10.5.5-linux-x86_64-dbg/bin/mysqld --no-defaults --core-'.
 
Program terminated with signal SIGABRT, Aborted.
 
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6)
 
    at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
 
[Current thread is 1 (Thread 0x14ab87e56700 (LWP 2131673))]
 
(gdb) bt
 
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
 
#1  0x00005575886144d7 in my_write_core (sig=sig@entry=6) at /test/10.5_dbg/mysys/stacktrace.c:518
 
#2  0x0000557587dce9ba in handle_fatal_signal (sig=6) at /test/10.5_dbg/sql/signal_handler.cc:330
 
#3  <signal handler called>
 
#4  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
 
#5  0x000014ab860ec8b1 in __GI_abort () at abort.c:79
 
#6  0x000014ab860dc42a in __assert_fail_base (fmt=0x14ab86263a38 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x557588af5720 "file->s->base.reclength < file->s->vreclength", file=file@entry=0x557588af54e8 "/test/10.5_dbg/storage/myisam/ha_myisam.cc", line=line@entry=976, function=function@entry=0x557588af6040 <ha_myisam::setup_vcols_for_repair(st_handler_check_param*)::__PRETTY_FUNCTION__> "void ha_myisam::setup_vcols_for_repair(HA_CHECK*)") at assert.c:92
 
#7  0x000014ab860dc4a2 in __GI___assert_fail (assertion=assertion@entry=0x557588af5720 "file->s->base.reclength < file->s->vreclength", file=file@entry=0x557588af54e8 "/test/10.5_dbg/storage/myisam/ha_myisam.cc", line=line@entry=976, function=function@entry=0x557588af6040 <ha_myisam::setup_vcols_for_repair(st_handler_check_param*)::__PRETTY_FUNCTION__> "void ha_myisam::setup_vcols_for_repair(HA_CHECK*)") at assert.c:101
 
#8  0x00005575885a7920 in ha_myisam::setup_vcols_for_repair (this=this@entry=0x14ab638376a0, param=param@entry=0x14ab638fc0a0) at /test/10.5_dbg/storage/myisam/ha_myisam.cc:976
 
#9  0x00005575885a8ee4 in ha_myisam::repair (this=0x14ab638376a0, thd=0x14ab63815088, check_opt=0x14ab6381a338) at /test/10.5_dbg/storage/myisam/ha_myisam.cc:1158
 
#10 0x0000557587ddcce5 in handler::ha_repair (this=0x14ab638376a0, thd=0x14ab63815088, check_opt=0x14ab6381a338) at /test/10.5_dbg/sql/handler.cc:4618
 
#11 0x0000557587c88dc0 in mysql_admin_table (thd=thd@entry=0x14ab63815088, tables=tables@entry=0x14ab63874168, check_opt=check_opt@entry=0x14ab6381a338, operator_name=operator_name@entry=0x557588af5426 "repair", lock_type=lock_type@entry=TL_WRITE, org_open_for_modify=org_open_for_modify@entry=true, repair_table_use_frm=false, extra_open_options=32, prepare_func=0x557587c87081 <prepare_for_repair(THD*, TABLE_LIST*, HA_CHECK_OPT*)>, operator_func=(int (handler::*)(handler * const, THD *, HA_CHECK_OPT *)) 0x557587ddccb4 <handler::ha_repair(THD*, st_ha_check_opt*)>, view_operator_func=0x557587c20dde <view_repair(THD*, TABLE_LIST*, st_ha_check_opt*)>) at /test/10.5_dbg/sql/sql_admin.cc:781
 
#12 0x0000557587c8af62 in Sql_cmd_repair_table::execute (this=<optimized out>, thd=0x14ab63815088) at /test/10.5_dbg/sql/sql_admin.cc:1410
 
#13 0x0000557587b27e4a in mysql_execute_command (thd=thd@entry=0x14ab63815088) at /test/10.5_dbg/sql/sql_parse.cc:5951
 
#14 0x0000557587b2f752 in mysql_parse (thd=thd@entry=0x14ab63815088, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x14ab87e55350, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:7993
 
#15 0x0000557587b1c204 in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x14ab63815088, packet=packet@entry=0x14ab63867089 "", packet_length=packet_length@entry=20, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:1866
 
#16 0x0000557587b1a9de in do_command (thd=0x14ab63815088) at /test/10.5_dbg/sql/sql_parse.cc:1347
 
#17 0x0000557587c76c3b in do_handle_one_connection (connect=<optimized out>, connect@entry=0x14ab66cc7808, put_in_cache=put_in_cache@entry=true) at /test/10.5_dbg/sql/sql_connect.cc:1411
 
#18 0x0000557587c77357 in handle_one_connection (arg=arg@entry=0x14ab66cc7808) at /test/10.5_dbg/sql/sql_connect.cc:1313
 
#19 0x00005575880daca8 in pfs_spawn_thread (arg=0x14ab84c46508) at /test/10.5_dbg/storage/perfschema/pfs.cc:2201
 
#20 0x000014ab86dcf6db in start_thread (arg=0x14ab87e56700) at pthread_create.c:463
 
#21 0x000014ab861cda3f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Bug confirmed present in:
MariaDB: 10.2.33 (dbg), 10.3.24 (dbg), 10.4.14 (dbg), 10.5.5 (dbg)

Bug confirmed not present in:
MariaDB: 10.1.46 (dbg), 10.1.46 (opt), 10.2.33 (opt), 10.3.24 (opt), 10.4.14 (opt), 10.5.5 (opt)
MySQL: 5.5.62 (dbg), 5.5.62 (opt), 5.6.47 (dbg), 5.6.47 (opt), 5.7.29 (dbg), 5.7.29 (opt), 8.0.19 (dbg), 8.0.19 (opt)

Comment by Roel Van de Paar [ 2020-07-22 ]

Possibly related to MDEV-17153

Comment by Roel Van de Paar [ 2020-09-09 ]

Another testcase

USE test;
 
CREATE TABLE t(c TEXT GENERATED ALWAYS AS (1) VIRTUAL, INDEX i(c(1))) ENGINE=MyISAM;
 
OPTIMIZE TABLE t;

Leads to:

10.5.6 c5517cd86440b6669509211b1ad10f837a929952 (Debug)

 
mysqld: /test/10.5_dbg/storage/myisam/ha_myisam.cc:976: void ha_myisam::setup_vcols_for_repair(HA_CHECK*): Assertion `file->s->base.reclength < file->s->vreclength' failed.

10.5.6 c5517cd86440b6669509211b1ad10f837a929952 (Debug)

 
Core was generated by `/test/MD080920-mariadb-10.5.6-linux-x86_64-dbg/bin/mysqld --no-defaults --core-'.
 
Program terminated with signal SIGABRT, Aborted.
 
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6)
 
    at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
 
[Current thread is 1 (Thread 0x1485baa89700 (LWP 1323448))]
 
(gdb) bt
 
#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ../sysdeps/unix/sysv/linux/pthread_kill.c:57
 
#1  0x0000562717ee74e8 in my_write_core (sig=sig@entry=6) at /test/10.5_dbg/mysys/stacktrace.c:424
 
#2  0x00005627176ae56b in handle_fatal_signal (sig=6) at /test/10.5_dbg/sql/signal_handler.cc:330
 
#3  <signal handler called>
 
#4  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
 
#5  0x00001485b8d1f8b1 in __GI_abort () at abort.c:79
 
#6  0x00001485b8d0f42a in __assert_fail_base (fmt=0x1485b8e96a38 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x5627183ceea8 "file->s->base.reclength < file->s->vreclength", file=file@entry=0x5627183ceca8 "/test/10.5_dbg/storage/myisam/ha_myisam.cc", line=line@entry=976, function=function@entry=0x5627183cf800 <ha_myisam::setup_vcols_for_repair(st_handler_check_param*)::__PRETTY_FUNCTION__> "void ha_myisam::setup_vcols_for_repair(HA_CHECK*)") at assert.c:92
 
#7  0x00001485b8d0f4a2 in __GI___assert_fail (assertion=assertion@entry=0x5627183ceea8 "file->s->base.reclength < file->s->vreclength", file=file@entry=0x5627183ceca8 "/test/10.5_dbg/storage/myisam/ha_myisam.cc", line=line@entry=976, function=function@entry=0x5627183cf800 <ha_myisam::setup_vcols_for_repair(st_handler_check_param*)::__PRETTY_FUNCTION__> "void ha_myisam::setup_vcols_for_repair(HA_CHECK*)") at assert.c:101
 
#8  0x0000562717e7a080 in ha_myisam::setup_vcols_for_repair (this=this@entry=0x1485964376a0, param=param@entry=0x1485964fc0a0) at /test/10.5_dbg/storage/myisam/ha_myisam.cc:976
 
#9  0x0000562717e7bcab in ha_myisam::optimize (this=0x1485964376a0, thd=0x148596415088, check_opt=0x14859641a4b8) at /test/10.5_dbg/storage/myisam/ha_myisam.cc:1213
 
#10 0x00005627176bcf31 in handler::ha_optimize (this=0x1485964376a0, thd=0x148596415088, check_opt=0x14859641a4b8) at /test/10.5_dbg/sql/handler.cc:4727
 
#11 0x0000562717565811 in mysql_admin_table (thd=thd@entry=0x148596415088, tables=tables@entry=0x148596474160, check_opt=check_opt@entry=0x14859641a4b8, operator_name=operator_name@entry=0x562718079721 "optimize", lock_type=lock_type@entry=TL_WRITE, org_open_for_modify=org_open_for_modify@entry=true, repair_table_use_frm=false, extra_open_options=0, prepare_func=0x0, operator_func=(int (handler::*)(handler * const, THD *, HA_CHECK_OPT *)) 0x5627176bcece <handler::ha_optimize(THD*, st_ha_check_opt*)>, view_operator_func=0x0) at /test/10.5_dbg/sql/sql_admin.cc:791
 
#12 0x0000562717567b7d in Sql_cmd_optimize_table::execute (this=<optimized out>, thd=0x148596415088) at /test/10.5_dbg/sql/sql_admin.cc:1385
 
#13 0x0000562717400b44 in mysql_execute_command (thd=thd@entry=0x148596415088) at /test/10.5_dbg/sql/sql_parse.cc:5952
 
#14 0x00005627174084b8 in mysql_parse (thd=thd@entry=0x148596415088, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x1485baa88350, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:7994
 
#15 0x00005627173f4ee8 in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x148596415088, packet=packet@entry=0x148596467089 "", packet_length=packet_length@entry=16, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.5_dbg/sql/sql_parse.cc:1867
 
#16 0x00005627173f36d2 in do_command (thd=0x148596415088) at /test/10.5_dbg/sql/sql_parse.cc:1348
 
#17 0x0000562717552a27 in do_handle_one_connection (connect=<optimized out>, connect@entry=0x1485998d4808, put_in_cache=put_in_cache@entry=true) at /test/10.5_dbg/sql/sql_connect.cc:1410
 
#18 0x000056271755314b in handle_one_connection (arg=arg@entry=0x1485998d4808) at /test/10.5_dbg/sql/sql_connect.cc:1312
 
#19 0x00005627179bd784 in pfs_spawn_thread (arg=0x1485b7846508) at /test/10.5_dbg/storage/perfschema/pfs.cc:2201
 
#20 0x00001485b9a026db in start_thread (arg=0x1485baa89700) at pthread_create.c:463
 
#21 0x00001485b8e00a3f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Bug confirmed present in:
MariaDB: 10.2.34 (dbg), 10.3.25 (dbg), 10.4.15 (dbg), 10.5.6 (dbg)

Bug confirmed not present in:
MariaDB: 10.1.47 (dbg), 10.1.47 (opt), 10.2.34 (opt), 10.3.25 (opt), 10.4.15 (opt), 10.5.6 (opt)
MySQL: 5.5.62 (dbg), 5.5.62 (opt), 5.6.47 (dbg), 5.6.47 (opt), 5.7.29 (dbg), 5.7.29 (opt), 8.0.19 (dbg), 8.0.19 (opt)

Comment by Roel Van de Paar [ 2020-09-09 ]

Unique bug ID's seen so far

file->s->base.reclength < file->s->vreclength|SIGABRT|ha_myisam::setup_vcols_for_repair|ha_myisam::repair|handler::ha_repair|mysql_admin_table
 
file->s->base.reclength < file->s->vreclength|SIGABRT|ha_myisam::setup_vcols_for_repair|ha_myisam::optimize|handler::ha_optimize|mysql_admin_table
 
file->s->base.reclength < file->s->vreclength|SIGABRT|ha_myisam::setup_vcols_for_repair|ha_myisam::enable_indexes|ha_myisam::end_bulk_insert|handler::ha_end_bulk_insert

Comment by Oleksandr Byelkin [ 2021-03-24 ]

ok to push

Comment by Roel Van de Paar [ 2022-05-08 ]

See MDEV-28514

Generated at Thu Feb 08 08:48:24 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.