[MDEV-17835] Remove wsrep-sst-method=xtrabackup Created: 2018-11-26 Updated: 2021-05-18 Resolved: 2019-01-23 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Galera SST |
| Affects Version/s: | 10.3 |
| Fix Version/s: | 10.4.3, 10.3.13 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Jan Lindström (Inactive) | Assignee: | Julius Goryavsky |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
| Comments |
| Comment by Sergei Golubchik [ 2018-11-26 ] | |||||||||||||||||||||
|
It'll break setups that use these methods (assuming there were cases when they worked). Perhaps a less disruptive approach would be to symlink xtrabackup and xtrabackup-v2 scripts to mariabackup? | |||||||||||||||||||||
| Comment by Marko Mäkelä [ 2018-11-26 ] | |||||||||||||||||||||
|
As far as I can tell, xtrabackup is invoking InnoDB redo log processing by invoking innobase_start_or_create_for_mysql(), which in turn invokes recv_recovery_from_checkpoint_start() and then recv_find_max_checkpoint(), which should fail due to redo log format mismatch:
This is the code that I originally added in MySQL 5.7.9. jplindst, you claimed that the Galera tests for xtrabackup worked in 10.3. Can you confirm that? Could it be that the errors from xtrabackup were completely ignored? | |||||||||||||||||||||
| Comment by Jan Lindström (Inactive) [ 2018-11-26 ] | |||||||||||||||||||||
|
SST tests fail and innobackup.backup.log contains
| |||||||||||||||||||||
| Comment by Marko Mäkelä [ 2018-11-26 ] | |||||||||||||||||||||
|
I believe that Docs/README-wsrep should stop mentioning xtrabackup already starting with MariaDB Server 10.1 or 10.2, and definitely must do so starting with 10.3. Other notable files listed by git grep -l xtrabackup include the following:
| |||||||||||||||||||||
| Comment by Jan Lindström (Inactive) [ 2018-11-28 ] | |||||||||||||||||||||
|
Instructions
| |||||||||||||||||||||
| Comment by Julius Goryavsky [ 2018-12-17 ] | |||||||||||||||||||||
|
The xtrabackup-related scripts are removed and corresponding methods | |||||||||||||||||||||
| Comment by Marko Mäkelä [ 2018-12-27 ] | |||||||||||||||||||||
|
I think that several references to xtrabackup or innobackupex still have to be removed. Please refer to my comments. |