[MDEV-17797] Add ASAN poisoning for mem_heap_t Created: 2018-11-22 Updated: 2019-01-15 Resolved: 2019-01-15 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - InnoDB |
| Fix Version/s: | 10.4.2, 10.1.38, 10.0.38, 10.2.22, 10.3.13 |
| Type: | Task | Priority: | Major |
| Reporter: | Eugene Kosov (Inactive) | Assignee: | Marko Mäkelä |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Basically mem_heap_t should poison all not yet allocated and all freed memory. Opposite for MEM_ROOT it's not instrumented at all. |
| Comments |
| Comment by Eugene Kosov (Inactive) [ 2018-11-27 ] |
|
Looks like it's actually implemented in 5.5. But not in 10.0+ due to merge error. I consider it a result of macro complications and will fix in 10.0 by intruducing MY_ASAN_POISON_MEMORY_REGION() macro. |
| Comment by Marko Mäkelä [ 2019-01-10 ] |
|
I think that we should resolve the merge error differently, by making the InnoDB interface to ASAN and Valgrind in 10.0 more similar to how it is in 5.5. |