[MDEV-17727] galera-4 install test in buildbot doesn't install galera-4 Created: 2018-11-15  Updated: 2018-12-24  Resolved: 2018-12-04

Status: Closed
Project: MariaDB Server
Component/s: Galera, Galera Arbitrator garbd
Affects Version/s: None
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Daniel Bartholomew Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 0
Labels: None


 Description   

The install test for galera builds in buildbot universally tries to install galera-3 and galera-arbitrator-3:

sudo sh -c "DEBIAN_FRONTEND=noninteractive MYSQLD_STARTUP_TIMEOUT=180 apt-get install --allow-unauthenticated -y galera-3 galera-arbitrator-3"

This is (obviously) not appropriate when building/testing galera-4 packages.

The test needs to be changed to install either galera-3 or galera-4 packages depending on which one is being built.

 Comments   
Comment by Daniel Bartholomew [ 2018-11-29 ]

The test has been updated to install the correct galera packages, but I've discovered a new issue: the garbd binary is not in the galera-arbitrator-4 package.

Comment by Daniel Bartholomew [ 2018-11-29 ]

Here's a comparison of the output of dpkg -c for both galera-arbitrator-3 and galera-arbitrator-4 packages:

galera-arbitrator-3:

dbart@hasky:$ dpkg -c ./galera-arbitrator-3_25.3.25-xenial_amd64.deb 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/share/
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/share/man/
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/share/man/man8/
 
-rw-r--r-- root/root      1124 2018-11-28 15:39 ./usr/share/man/man8/garbd.8.gz
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/share/doc/
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/share/doc/galera-arbitrator-3/
 
-rw-r--r-- root/root       320 2018-11-28 15:34 ./usr/share/doc/galera-arbitrator-3/changelog.Debian.gz
 
-rw-r--r-- root/root      5761 2018-11-28 15:28 ./usr/share/doc/galera-arbitrator-3/copyright
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./usr/bin/
 
-rwxr-xr-x root/root  25201856 2018-11-28 15:37 ./usr/bin/garbd
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./etc/
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./etc/init.d/
 
-rwxr-xr-x root/root      3851 2018-11-28 15:28 ./etc/init.d/garb
 
drwxr-xr-x root/root         0 2018-11-28 15:39 ./etc/default/
 
-rw-r--r-- root/root       511 2018-11-28 15:28 ./etc/default/garb

galera-arbitrator-4:

dbart@hasky:$ dpkg -c ./galera-arbitrator-4_26.4.0-xenial_amd64.deb 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./usr/
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./usr/share/
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./usr/share/doc/
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./usr/share/doc/galera-arbitrator-4/
 
-rw-r--r-- root/root       366 2018-11-29 14:50 ./usr/share/doc/galera-arbitrator-4/changelog.Debian.gz
 
-rw-r--r-- root/root      5761 2018-11-29 14:44 ./usr/share/doc/galera-arbitrator-4/copyright
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./etc/
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./etc/init.d/
 
-rwxr-xr-x root/root      3851 2018-11-29 14:44 ./etc/init.d/garb
 
drwxr-xr-x root/root         0 2018-11-29 14:55 ./etc/default/
 
-rw-r--r-- root/root       511 2018-11-29 14:44 ./etc/default/garb

The man page (garbd.8.gz) is also missing, but the bigger issue is the missing garbd.

Comment by Daniel Bartholomew [ 2018-11-29 ]

jplindst: Can you or someone at codership take a look at why the garbd binary is not being included in the galera-4 debian/ubuntu packages?

Here's a log of a build to get you started: https://buildbot.askmonty.org/buildbot/builders/kvm-deb-bionic-amd64-gal/builds/19/steps/compile/logs/stdio

If you search for `dh_install` you'll get to the part of the log where it's creating the packages. In the section where there's a `cp` command to copy the ./libgalera_smm.so file to the correct place there should also be a command to copy the garbd binary to the correct place, but it is missing (not sure if that is because garbd never got built, or some other reason).

Here's the log of the install test:
https://buildbot.askmonty.org/buildbot/builders/kvm-deb-bionic-amd64-gal/builds/19/steps/test/logs/stdio

If you search for `+ garbd --version` you'll find the part where it tries to run that command and fails. Just above there in the log you can see the output that shows that the galera-4 and galera-arbitrator-4 packages have been successfully installed.

Thanks.

Comment by Teemu Ollakka [ 2018-11-30 ]

The reason for missing garbd binary and manpages was missing galera-arbitrator-4.install and galera-arbitrator-4.manpages files, the galera-arbitrator-3 files were not renamed appropriately. After renaming the files, the galera-arbitrator-4 package seems to contain correct files:

# dpkg -c ../galera-arbitrator-4_26.4.0-1_amd64.deb 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./etc/
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./etc/default/
 
-rw-r--r-- root/root       511 2018-11-13 13:10 ./etc/default/garb
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./etc/init.d/
 
-rwxr-xr-x root/root      3851 2018-11-13 13:10 ./etc/init.d/garb
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/bin/
 
-rwxr-xr-x root/root   1737232 2018-11-13 13:10 ./usr/bin/garbd
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/share/
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/share/doc/
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/share/doc/galera-arbitrator-4/
 
-rw-r--r-- root/root       317 2018-11-13 13:10 ./usr/share/doc/galera-arbitrator-4/changelog.Debian.gz
 
-rw-r--r-- root/root      5761 2018-11-13 13:10 ./usr/share/doc/galera-arbitrator-4/copyright
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/share/man/
 
drwxr-xr-x root/root         0 2018-11-13 13:10 ./usr/share/man/man8/
 
-rw-r--r-- root/root      1124 2018-11-13 13:10 ./usr/share/man/man8/garbd.8.gz

Comment by Daniel Bartholomew [ 2018-12-04 ]

With the fixes from Teemu things are looking good for the Deb packages. Closing issue.

Generated at Thu Feb 08 08:38:39 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.