[MDEV-17601] MariaDB Galera does not expect 'mbstream' as streamfmt in the [sst] section and defaults to non-default 'tar' Created: 2018-11-02  Updated: 2021-07-08  Resolved: 2020-01-21

Status: Closed
Project: MariaDB Server
Component/s: Galera SST
Affects Version/s: 10.1.36
Fix Version/s: 10.1.44, 10.2.31, 10.3.22, 10.4.12

Type: Bug Priority: Critical
Reporter: Claudio Nanni Assignee: Julius Goryavsky
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-15730 mariabackup: rename --stream=xbstream... Closed

 Description   

Using:

[sst]
streamfmt=mbstream

causes SST to fail because the format defaults for some reason to 'tar'

A quick investigation led to find that while wsrep_sst_mariabackup uses 'mbstream' as binary for streaming, it only handles the parameter value 'xbstream'.

    if [[ $sfmt == 'xbstream' ]];then
        wsrep_log_info "Streaming with xbstream"
        if [[ "$WSREP_SST_OPT_ROLE"  == "joiner" ]];then
            strmcmd="${XBSTREAM_BIN} -x"
....

XBSTREAM_BIN=mbstream

Maybe it would be useful to have wsrep_sst_mariabackup accept both xbstream and mbstream and map them both to 'mbstream' so to assure a smooth migration for who migrates from xtrabackup sst method to mariabackup.

Or, imho, if it should only accept one value, that would be 'mbstream' in MariaDB Galera using mariabackup as sst method.



 Comments   
Comment by Julius Goryavsky [ 2020-01-21 ]

Fixed, https://github.com/MariaDB/server/commit/982294ac1680938ac9223fb64a64e21f0cbc322a

Generated at Thu Feb 08 08:37:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.