[MDEV-17250] Remove unused Item_copy_xxx Created: 2018-09-20  Updated: 2018-09-20  Resolved: 2018-09-20

Status: Closed
Project: MariaDB Server
Component/s: OTHER
Fix Version/s: 5.5.62, 10.0.37, 10.2.18, 10.3.11, 10.4.0, 10.1.37

Type: Task Priority: Critical
Reporter: Alexander Barkov Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: None


 Description   

In this class hierarchy:

  Item_copy
 
    Item_copy_string
 
    Item_copy_int
 
      Item_copy_uint
 
    Item_copy_float
 
    Item_copy_decimal

Only Item_copy_string is used in the code.

We'll remove all unused classes.
We'll also make sure to add tests from the original commit that added those classes:

commit 73481404656a954b314398f26ee7b4e3aec14282
 
Author: Georgi Kodinov <joro@sun.com>
 
Date:   Mon May 25 11:00:40 2009 +0300
 
 
 
    Bug #44399 : crash with statement using TEXT columns, aggregates, GROUP BY, and
 
    HAVING

This problem seems to be earlier fixed in a different way in MariaDB, without using Item_copy_(int|uint|float|decimal).

 Comments   
Comment by Alexander Barkov [ 2018-09-20 ]

All tests seem to present in MariaDB-5.5.

Generated at Thu Feb 08 08:35:02 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.