[MDEV-17172] ALTER TABLE on the base table of a OQGRAPH table leads to crash Created: 2018-09-11 Updated: 2023-04-27 |
|
| Status: | Confirmed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - OQGRAPH |
| Affects Version/s: | 10.3.9, 10.2, 10.3 |
| Fix Version/s: | 10.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Oli Sennhauser | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | columns, crash, drop, oqgraph | ||
| Environment: |
Linux, generic binaries |
||
| Issue Links: |
|
||||||||||||
| Description |
|
|
| Comments |
| Comment by Alice Sherepa [ 2018-09-12 ] | ||||||||||||||||||||||
|
Thanks for the report!
on 10.0-10.1
| ||||||||||||||||||||||
| Comment by Marko Mäkelä [ 2018-09-24 ] | ||||||||||||||||||||||
|
Executing table-rebuilding DDL statements (such as certain ALTER TABLE or OPTIMIZE TABLE, or starting with Given that the implementation of DROP COLUMN inside InnoDB has not changed between MariaDB 10.0 and 10.3, it seems to me that the locking must have changed. Without debugging, it seems to me that no metadata lock (MDL) on the base table is being held in 10.2, while it is being held (and blocking the ALTER TABLE) in 10.0 and 10.1. pprkut, how does the locking of the base table work in OQGRAPH? Has it changed in MariaDB Server 10.2? | ||||||||||||||||||||||
| Comment by Sergey Vojtovich [ 2018-09-24 ] | ||||||||||||||||||||||
|
This is oqgraph bug. It opens a table, bypassing table cache and keeps TABLE instance open. At some point ALTER TABLE issues tdc_remove_table() to make sure there're no stale TABLE instances left. However it won't notice such unregistered TABLE instance. Eventually we get this assertion failure. | ||||||||||||||||||||||
| Comment by Marko Mäkelä [ 2018-09-24 ] | ||||||||||||||||||||||
|
pprkut, I hope you can provide a fix for OQGRAPH. | ||||||||||||||||||||||
| Comment by Heinz Wiesinger [ 2018-09-24 ] | ||||||||||||||||||||||
|
This is most likely related to MDEV-11342. I discussed this a bit with Sergey at the meetup, but didn't get to actually work on a fix yet. | ||||||||||||||||||||||
| Comment by richardeaxon [ 2019-01-11 ] | ||||||||||||||||||||||
|
Any update on this and MDEV-11342? | ||||||||||||||||||||||
| Comment by Heinz Wiesinger [ 2019-01-11 ] | ||||||||||||||||||||||
|
I made a little progress a couple months ago in prototyping a solution, but it's rather complicated to fix correctly and I haven't had time to continue since. It's regularly on my mind though, so I hope I can revisit this soon. |