[MDEV-17093] Print version_source_revision in the error log upon server startup Created: 2018-08-29  Updated: 2023-01-07  Resolved: 2023-01-06

Status: Closed
Project: MariaDB Server
Component/s: Server
Fix Version/s: 10.11.2, 11.0.1, 10.3.38, 10.4.28, 10.5.19, 10.6.12, 10.7.8, 10.8.7, 10.9.5, 10.10.3

Type: Task Priority: Major
Reporter: Elena Stepanova Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: beginner-friendly

Issue Links:
Relates
relates to MDEV-21046 Print server version to error log ins... Open
relates to MDEV-6873 On startup please make MariaDB report... Closed
relates to MDEV-10648 mysqld --log-error prints on stdout a... Confirmed
relates to MDEV-20287 Have the server process print a "star... Open
relates to MDEV-20344 startup messages belong in stderr/err... Closed
relates to MDEV-21711 Log: "Server Version xx.xx.xx startin... Open
relates to MDEV-27933 setting the version system server var... Closed

 Description   

The source revision variable implemented in the scope of MDEV-12583 was a useful addition. It would have been much more useful if it was also reflected in the error log. I don't think that's where we should be concerned about one extra line per server runtime session.

I've set the version to 10.3 because I don't think this kind of change breaks any post-GA rules, but please feel free to change it to 10.4 if it does.

It could also be useful if handle_fatal_signal() displayed the source code revision.

 Comments   
Comment by Haidong Ji [ 2021-12-27 ]

`SOURCE_REVISION` looks to be pretty useful information in the log.

I've made some good progress and got it this info printed to my local build already. I would like to work on and finish this story.

Comment by Daniel Black [ 2022-10-26 ]

https://github.com/MariaDB/server/pull/1979 for review that covers a bunch of related MDEVs all in two commits.

Comment by Daniel Black [ 2023-01-06 ]

Same review in MDEV-20344.

Thanks for the patch haidong

Generated at Thu Feb 08 08:33:51 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.