Just a warning from a parano compiler.

Just an ignored bug from a developer who can't code to the standard of the compiler.

When you start ignoring warnings you get code that works by pure dumb luck. You know the difference between a pointer and value right?
https://github.com/MariaDB/server/pull/808

Or warnings like CONC-329 that actually change the behaviour.

A culture of ignoring warnings or attributing them to parano compliers isn't very reassuring and reflects beyond the connect engine to mariadb overall.

Sure enough, but it depends on the warning. I just spent several days fixing MDEV-16672 by removing many warnings some of them showing the possibility of real bugs. Just to say that I have no culture of ignoring warnings.

But this one is the most stupid one I know. It just says that instead of:

PQRYRES JSONColumns(PGLOBAL g, PCSZ db, PCSZ dsn, PTOS topt, bool info)

{

...

}

this compiler requires:

PQRYRES JSONColumns(PGLOBAL g, PCSZ db, PCSZ dsn, PTOS topt, bool info);

PQRYRES JSONColumns(PGLOBAL g, PCSZ db, PCSZ dsn, PTOS topt, bool info)

{

...

}

Why not but, in addition, if this is regarded as a bug, it is a gcc compiler bug. Indeed, this declaration does exist in tabjson.h line 19 that is included by tabjson.cpp (unless perhaps you are using an old MariaDB version?)

This is why I reported it as "Not a bug" and not "Won't fix" because it was not ignored but already fixed.

Anyway, thanks for reporting warnings that are not issued by all compilers, but because they are reported as "bugs", they should not be over qualify as "Major" when they are clearly not.