[MDEV-16668] Naming consistency for storage engines and plugins Created: 2018-07-03  Updated: 2018-07-18

Status: Open
Project: MariaDB Server
Component/s: Plugins
Affects Version/s: 5.5, 10.0, 10.1, 10.2, 10.3
Fix Version/s: 10.4

Type: Bug Priority: Minor
Reporter: Michael Xu Assignee: Sergei Golubchik
Resolution: Unresolved Votes: 0
Labels: None


 Description    

MariaDB [(none)]> SET GLOBAL gtid_pos_auto_engines = 'InnoDB,TokuDB,RocksDB';
 
Query OK, 0 rows affected (0.000 sec)
 
 
 
MariaDB [(none)]> show variables like 'gtid%';
 
+------------------------+-----------------------+
 
| Variable_name          | Value                 |
 
+------------------------+-----------------------+
 
| gtid_binlog_pos        | 10-15183-59           |
 
| gtid_binlog_state      | 10-15183-59           |
 
| gtid_current_pos       | 10-15183-59           |
 
| gtid_domain_id         | 10                    |
 
| gtid_ignore_duplicates | OFF                   |
 
| gtid_pos_auto_engines  | InnoDB,TokuDB,ROCKSDB |
 
| gtid_seq_no            | 0                     |
 
| gtid_slave_pos         |                       |
 
| gtid_strict_mode       | ON                    |
 
+------------------------+-----------------------+
 
9 rows in set (0.002 sec)

It should be RocksDB considering InnoDB/TokuDB.

 Comments   
Comment by Elena Stepanova [ 2018-07-18 ]

It's not about the variable, it's plugin naming in general

select plugin_name from information_schema.all_plugins where plugin_type = 'STORAGE ENGINE';
 
+--------------------+
 
| plugin_name        |
 
+--------------------+
 
| binlog             |
 
| wsrep              |
 
| CSV                |
 
| MRG_MyISAM         |
 
| MyISAM             |
 
| MEMORY             |
 
| Aria               |
 
| SEQUENCE           |
 
| PERFORMANCE_SCHEMA |
 
| InnoDB             |
 
| partition          |
 
| TokuDB             |
 
| SPHINX             |
 
| BLACKHOLE          |
 
| CONNECT            |
 
| SPIDER             |
 
| EXAMPLE            |
 
| FEDERATED          |
 
| ROCKSDB            |
 
| FEDERATED          |
 
| TEST_SQL_DISCOVERY |
 
| ARCHIVE            |
 
| Mroonga            |
 
+--------------------+
 
23 rows in set (0.03 sec)

(Same mix of upper/mixed cases for other plugins).

I don't know if there is a general naming convention for plugins. If there is, not following it would be a bug. If there isn't one, maybe it could be considered a feature request to create one. I'll leave it to serg to decide, the fix version is set arbitrarily, just to have something there.

Generated at Thu Feb 08 08:30:39 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.