[MDEV-16605] Always include buf_madvise_do_dump in binaries. Created: 2018-06-28 Updated: 2022-08-02 Resolved: 2022-08-02 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Server |
| Fix Version/s: | 10.3.36, 10.4.26, 10.5.17, 10.6.9, 10.7.5, 10.8.4, 10.9.2, 10.10.1 |
| Type: | Task | Priority: | Minor |
| Reporter: | Jean-François Gagné | Assignee: | Daniel Black |
| Resolution: | Fixed | Votes: | 2 |
| Labels: | beginner-friendly | ||
| Issue Links: |
|
||||||||
| Description |
|
Hi, as described in [1], the buf_madvise_do_dump function is added but never called by the server; it is there to be called from a debugger to re-enable full core dump if needed. [1]: https://github.com/MariaDB/server/pull/364/commits/b600f30786816e33c1706dd36cdabf21034dc781 As described in [2], this function is not present in the Linux generic binaries. This leads to wasted time in debugging. As described in [2], if would be better to always have this function in binaries and to behave differently depending if the "no InnoDB Buffer Pool in core dumps" feature is included or not in the binaries. An example of such behavior could be to return a non-zero value when failing with a detailed message in the error logs. Please consider implementing this for easing the usage of MariaDB. Thanks in advance, JFG |
| Comments |
| Comment by Daniel Black [ 2019-02-11 ] |
|
looks like its just the kernel version where the build happened that is preventing this. |
| Comment by Daniel Black [ 2022-05-16 ] |
|
Found function attribute "used" which might achieve this goal. |
| Comment by Daniel Black [ 2022-08-02 ] |
|
Finally :smile:. |