[MDEV-16318] mysqld_safe: use sh not bash Created: 2018-05-29  Updated: 2018-08-05  Resolved: 2018-08-05

Status: Closed
Project: MariaDB Server
Component/s: Packaging
Affects Version/s: 10.3
Fix Version/s: 10.3.8

Type: Bug Priority: Major
Reporter: Sergey Vojtovich Assignee: Otto Kekäläinen
Resolution: Fixed Votes: 1
Labels: contribution, foundation, regression

Issue Links:
Relates
relates to MDEV-6284 Merge downstream Debian/Ubuntu packag... Closed
relates to MDEV-14900 Upstream 10.4 debian patches Closed

 Description   

c902d5a changed this to bash.
This isn't appropriate as mysqld_safe is used by FreeBSD where there is no bash by default.

The original reason to use bash seems related to MDEV-3279 which
was a dash bug fixed in 2009 - https://git.kernel.org/pub/scm/utils/dash/dash.git/commit/?id=3800d4934391b144fd261a7957aea72ced7d47ea

Working around 9 year old fixed bugs shouldn't be done without considerations of other users. Debian/Ubuntu are using systemd now so the mysqld_safe implementation isn't as critical to them (right?).

Like 64094e1, some actual analysis was done in MDEV-14900 that could of been used instead of "validity of this has thus been vetted in production" (or more correctly, "as no-one has complained it must be right").

 Comments   
Comment by Daniel Black [ 2018-06-04 ]

Also PR#783 for reverting the mysqld_safe portion of 64094e1 due blatant Debianness being added to mysqld_safe.

Rushing to get very old debian patches upstream before a GA release without really showing a benefit?

There are distro bugs/PRs that are affecting users that could of been considered instead.

Comment by Otto Kekäläinen [ 2018-08-05 ]

This issue was closed via commits

https://github.com/MariaDB/server/commit/88a263eabb7a7b993c135ba6b91ef969a7c41bd3
https://github.com/MariaDB/server/commit/c10bed17ddaaa2635fe758a47d89a12c4169e31e

Credits danblack who made the pull requests!

Generated at Thu Feb 08 08:28:00 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.