[MDEV-16237] Remove or fix ut_timer_now() Created: 2018-05-21  Updated: 2020-04-16  Resolved: 2020-04-16

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.2.2, 10.3.0
Fix Version/s: 10.2.26, 10.1.41, 10.3.17, 10.4.7, 10.5.0

Type: Bug Priority: Major
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: regression-10.2

Issue Links:
Relates
relates to MDEV-5834 Merge Kakao Defragmentation implement... Closed

 Description   

The function ut_init_timer() is never called in MariaDB 10.2.2 or later, ever since the merge of InnoDB from MySQL 5.7.9. Because of this, the function pointer ut_timer_now() should point to ut_timer_none(), which will always return 0. The only caller appears to be btr_defragment_thread(). One of the effects could be that btr_defragment_item_t::last_processed is always a constant 0.

I would prefer to remove the compilation unit and to fix the defragmentation in some way so that it does not depend on the timestamp. We should perhaps test the performance of defragmentation compared to MariaDB 10.1, where the feature was introduced by MDEV-5834.



 Comments   
Comment by Marko Mäkelä [ 2020-04-16 ]

We replaced ut_timer_now() with my_internal_timer() in a change that was related to MDEV-14154.

Generated at Thu Feb 08 08:27:24 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.