[MDEV-16075] CTests failing Created: 2018-05-02 Updated: 2018-07-02 Resolved: 2018-07-02 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Tests |
| Affects Version/s: | 10.2.0 |
| Fix Version/s: | 5.5.62 |
| Type: | Bug | Priority: | Major |
| Reporter: | Teodor Mircea Ionita (Inactive) | Assignee: | Teodor Mircea Ionita (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Ubuntu 14.04+, macOS 10.13 |
||
| Issue Links: |
|
||||||||
| Description |
|
It looks like a couple of the CTests that are ran with make test constantly fail on macOS, Linux for the 10.0 branch:
Is this a known issue? How is running make test different than ./mtr --suite=unit? Is running make test advised in any case in favor of mtr? |
| Comments |
| Comment by Teodor Mircea Ionita (Inactive) [ 2018-05-02 ] |
|
It looks like the failing tests were introduced in 10.2. |
| Comment by Sergei Golubchik [ 2018-05-02 ] |
|
./mtr --suite=unit starts mysqld that unit tests are using. When you run them standalone, they fail as they cannot find the server. |
| Comment by Teodor Mircea Ionita (Inactive) [ 2018-05-02 ] |
|
In that case, wouldn't it be better if make test would run MTR in the first place? Or at least print a useful message? |
| Comment by Sergei Golubchik [ 2018-05-02 ] |
|
Absolutely. That would be ideal. |
| Comment by Vicențiu Ciorbaru [ 2018-05-03 ] |
|
We should properly fix this, just to make life easier for certain distributions. There is a problem with overriding `make test` command in cmake. CMake will issue a warning when this is done by creating a new target. There should be a "proper" way to get it working. |
| Comment by Teodor Mircea Ionita (Inactive) [ 2018-05-07 ] |
|
Managed to come up with a solution after quite a bit of headache. See PR at https://github.com/MariaDB/server/pull/746. It is based on the solution explained here https://stackoverflow.com/questions/31252228/cmake-and-ctests-default-test-command-skips-a-specially-named-test |
| Comment by Teodor Mircea Ionita (Inactive) [ 2018-05-17 ] |
| Comment by Sergei Golubchik [ 2018-05-17 ] |
|
Yes, I've seen it. Very nice trick. Looks like the best we could do... |
| Comment by Teodor Mircea Ionita (Inactive) [ 2018-07-02 ] |
|
Closing this since, as discussed, the fix in PR#746 was merged and reverted due to insufficient verbosity while running for a long time and no other solution is likely possible at the present moment with cmake/ctest 3.11. |