[MDEV-15961] Fix stacktraces under FreeBSD Created: 2018-04-21  Updated: 2020-08-17  Resolved: 2020-07-28

Status: Closed
Project: MariaDB Server
Component/s: Compiling, Platform FreeBSD, Server
Affects Version/s: 5.5, 10.0, 10.1, 10.2, 10.3
Fix Version/s: 10.1.46, 10.2.33, 10.3.24, 10.4.14, 10.5.5

Type: Bug Priority: Major
Reporter: Naram Qashat Assignee: Daniel Black
Resolution: Fixed Votes: 1
Labels: beginner-friendly, contribution, patch, upstream, upstream-fixed
Environment:

FreeBSD 11.1 under aarch64 primarily

Issue Links:
Problem/Incident
causes MDEV-23491 __bss_start breaks compilation of var... Closed
causes MDEV-23496 Fix build issue for MariaDB-10.5 on D... Closed

 Description   

Currently, MariaDB's server does not link under FreeBSD's aarch64 architecture due to the use of sbrk, which does not exist under that architecture. MySQL has corrected this issue with the following commit:

https://github.com/mysql/mysql-server/commit/75271e51d60bce8683423b208cbb43b11ca6060e

I have tested patching all current versions of MariaDB from FreeBSD's ports tree (5.5, 10.0, 10.1 and 10.2) under the aarch64 architecture, patching only mysys/stacktrace.c in all those versions, and it allows MariaDB to link. I have sent a patch to the FreeBSD ports tree here:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227628

If the patch that MySQL utilized was applied to all supported versions of MariaDB, it would allow MariaDB to work on more FreeBSD platforms.

 Comments   
Comment by Bernard Spil [ 2018-10-25 ]

Can the MariaDB devs please take a look?

Comment by Vincent Milum Jr [ 2020-07-18 ]

Can this please be looked into? It is preventing MariaDB 10.5 from compiling on FreeBSD Aarch64. The work-around patch can in theory be applied to the mariadb105-X ports like it is with the mariadb104-X and older ports, but considering how trivial this is, and already fixed in MySQL, this should be applied directly to the MariaDB core code base. The MySQL patch linked in the initial bug report can most likely be applied unmodified.

Comment by Daniel Black [ 2020-07-19 ]

Took the mariadb101-X ports patch from CyberBotX as 1620|https://github.com/MariaDB/server/pull/1629]. The patch works fine for me though I lack an aarch64 machine to test. I'm taking its existence in ports as sufficient testing.

I'm awaiting a license declaration from CyberBotX as the patch author.

Is there a a coverall license for patches and build changes in the FreeBSD ports that I could rely on in future?

Comment by Naram Qashat [ 2020-07-19 ]

I did not author the FreeBSD patches, I only applied the MySQL commit from the initial bug report to mysys/stacktrace.c and have since needed to have ~spil apply them to the mariadb103-X and mariadb104-X ports, and he will still need to apply it to the mariadb105-X port (I have already submitted a FreeBSD bug report to get that to happen). As such, I do not know what license the patches would be under, as they come from MySQL's commit. I shall also post this under the GitHub pull request you have referenced.

Comment by Daniel Black [ 2020-07-28 ]

Apologies for the delay.

Thanks Oracle for the patch

Generated at Thu Feb 08 08:25:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.