[MDEV-15792] Fix mtr to be able to wait for >1 exited mysqld Created: 2018-04-06 Updated: 2018-09-04 Resolved: 2018-09-04 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Galera, Tests |
| Affects Version/s: | 10.1, 10.2, 10.3 |
| Fix Version/s: | 10.1.36, 10.2.18, 10.3.10 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Jan Lindström (Inactive) | Assignee: | Sergei Golubchik |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | contribution, galera | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Description |
|
https://github.com/MariaDB/server/pull/665 Tests affected:
|
| Comments |
| Comment by Elena Stepanova [ 2018-04-12 ] | |||||||||||
|
I have no objections to the patch, but please push into a development tree first. | |||||||||||
| Comment by Elena Stepanova [ 2018-04-22 ] | |||||||||||
|
As it turns out, the patch requires amendments. First, it causes ERROR: wait_any failed when tests are run with testcase-timeout > 20. It is currently being fixed in https://github.com/MariaDB/server/pull/709#issuecomment-383030848. Another, and more trickier problem, is a race condition / non-determinism in processing actual crashes.
Possible reason is that SRVDIED logic lies outside the foreach $proc (keys(%keep_waiting_proc)) loop. so whenever the process remaining in $proc is not the server process, the crash doesn't get handled properly. | |||||||||||
| Comment by Elena Stepanova [ 2018-04-27 ] | |||||||||||
|
The version of pull request #709 of Apr 25 (with commit 9f0d9012) seems to be fixing problems observed locally and in buildbot, verified in buildbot on bb-10.2-mtr tree; however, please note review comments by serg, some changes have been requested. | |||||||||||
| Comment by Jan Lindström (Inactive) [ 2018-06-28 ] | |||||||||||