[MDEV-15743] build_prefix: prefix+category is too long <wait/synch/rwlock/> <proxy_protocol> Created: 2018-03-31  Updated: 2018-04-02  Resolved: 2018-04-02

Status: Closed
Project: MariaDB Server
Component/s: Admin statements
Affects Version/s: 10.3
Fix Version/s: 10.3.6

Type: Bug Priority: Major
Reporter: Elena Stepanova Assignee: Vladislav Vaintroub
Resolution: Fixed Votes: 0
Labels: None


 Description   

Start the server with --performance-schema, otherwise defaults.
Error log says:

10.3 556a9202cea39

 
2018-03-31 18:34:30 0 [Note] Plugin 'FEEDBACK' is disabled.
 
2018-03-31 18:34:31 0 [Note] InnoDB: Buffer pool(s) load completed at 180331 18:34:31
 
build_prefix: prefix+category is too long <wait/synch/rwlock/> <proxy_protocol>
 
2018-03-31 18:34:31 0 [Note] Server socket created on IP: '::'.
 
2018-03-31 18:34:31 0 [Note] Reading of all Master_info entries succeded
 
2018-03-31 18:34:31 0 [Note] Added new Master_info '' to hash table
 
2018-03-31 18:34:31 0 [Note] /data/bld/10.3/bin/mysqld: ready for connections.
 
Version: '10.3.6-MariaDB-debug'  socket: '/data/bld/10.3/data/tmp/mysql.sock'  port: 3306  Source distribution



 Comments   
Comment by Sergey Vojtovich [ 2018-03-31 ]

Introduced in 96ecf3ff 2018-03-21. strlen("wait/synch/rwlock/") + strlen("proxy_protocol") = 32, which perfectly hits limit of 32 for prefix+category length.

Either rename "proxy_protocol" (probably easier), or increase limit (probably harder). I would be very careful about increasing limit, I'd expect some PFS code to depend on it. Or at least make sure to analyse it before increasing the limit.

Also it'd be nice to replace (and get rid of) pfs_print_error with sql_print_error (don't forget to remove trailing \n).

Generated at Thu Feb 08 08:23:41 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.