[MDEV-15597] Add class Load_data_outvar and avoid using Item::STRING_ITEM for Item_user_var_as_out_param detection Created: 2018-03-19 Updated: 2019-02-23 Resolved: 2018-03-20 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | OTHER |
| Fix Version/s: | 10.3.6 |
| Type: | Task | Priority: | Major |
| Reporter: | Alexander Barkov | Assignee: | Alexander Barkov |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
This task is a self-contained change which is going to simplify MDEV-12927 and Under terms of In order to do it easier, we'll clean up the code in sql_load.cc not to use Item::STRING_ITEM for Item_user_var_as_out_param detection. Under terms of this task we'll do the following:
Code blocks like this (they repeat multiple times):
will be simplified to one line:
Additionally, replacing dangerous tests for Item::STRING_ITEM and dangerous casts to Item_user_var_as_out_param to virtual calls will remove potential bugs like |
| Comments |
| Comment by Alexander Barkov [ 2019-02-23 ] |
|
Backported to 10.2.23, as a part of |