[MDEV-15578] MyRocks: support zstandard compression where the distro allows it Created: 2018-03-15 Updated: 2020-10-03 Resolved: 2020-10-03 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - RocksDB |
| Fix Version/s: | 10.2.33, 10.3.24, 10.4.14, 10.5.5 |
| Type: | Task | Priority: | Major |
| Reporter: | Sergei Petrunia | Assignee: | Vicențiu Ciorbaru |
| Resolution: | Fixed | Votes: | 3 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
Modern distros include ZStandard compression library. Fedora 24 has these packages:
Ubuntu Xenial 16.04.3 LTS has
Debian Stretch has it: https://packages.debian.org/stretch/libzstd1 |
| Comments |
| Comment by Sergei Petrunia [ 2018-03-29 ] | |||||||
|
There might be a problem with fixing this in 10.2 as changing package dependencies in a stable version may create problems. In this case, let's compile/link/depend on ZStandard in 10.3. | |||||||
| Comment by Daniel Black [ 2018-05-24 ] | |||||||
|
Centos/RHEL 7 - there is an EPEL package for libzstd-devel: https://dl.fedoraproject.org/pub/epel/7/x86_64/Packages/l/ | |||||||
| Comment by MG [ 2020-08-05 ] | |||||||
|
Lack of zstd support in MyRocks for MariaDB was called out in a recent blog post and I have also wished to use this library for InnoDB page compression, so I voted on this issue. | |||||||
| Comment by Charalampos Michael [ 2020-10-03 ] | |||||||
|
Please add zstd support! | |||||||
| Comment by MG [ 2020-10-03 ] | |||||||
|
I see that in the changelog for 10233 and 10324 this was added, and the linked commit mentions also that 10414 and 1055 corrected the makefile problem. Quick test seems to show that zstd works in 10.4.14:
Sadly this fix being for storage/rocksdb/build_rocksdb.cmake and the libzstd dependency coming with MariaDB-rocksdb-engine means that innodb_compression_algorithm was unaffected. I suspect that the folks at MariaDB can now close this bug. | |||||||
| Comment by Daniel Black [ 2020-10-03 ] | |||||||
|
Thanks mg for confirming
|